Show ibus methods

[jeremypw]

Needs https://github.com/elementary/switchboard-plug-keyboard/pull/341 (OR manual entry of an ibus method into org.gnome.desktop.input-source.sources) to have an effect.

Also requires https://github.com/elementary/gala/pull/1041 to be installed to have selected IBus method use the expected keyboard layout.

[jeremypw]

Input source Xkb keyboard (UK English layout);

Input source Ibus Mozc Japanese using UK English keyboard layout

[ryonakano]

Input source Xkb keyboard (UK English layout);

Input source Ibus Mozc Japanese using UK English keyboard layout

It might be a little strange that we can check two radiobuttons here (xkb and ibus engine) :thinking:

[jeremypw]

It might be a little strange that we can check two radiobuttons here (xkb and ibus engine) :thinking:

How about if there is a separator between the xkb and ibus lists?

[jeremypw]

With separator:

[jeremypw]

A couple questions remain:

1) Do we need any headers to indicate what the two lists denote? 2) It is not immediately obvious that to turn off an ibus input method you click on a keyboard layout (even if it is already ticked). Do we need a "None" entry in the input method list (when input methods are available) or a switch?

Review requested from UX team.

[danirabbit]

1. I'm not certain a separator makes things clear on its own here; header labels make sense to me.
2. As long as that works conceptually in terms of how you think about input methods (ie: its clear that Ibus is a service you are enabling or disabling) a switch with the h4 style class could work and also act as the list header. The list of input methods could hide when it's turned off.

[jeremypw]

After latest commits:

[jeremypw]

The necessary Gala and Greeter fixes have now been merged.

[jeremypw]

@danrabbit Will you fix the header margin issue in the stylesheet or does something need to be done in this PR?

Based on Gtk.Grid

[danirabbit]

Yep I'll take care of that in the system stylesheet :)

[jeremypw]

One thing occurred to me - do we need to include code to detect pre-existing ibus input methods which were set up before the new version of the switchboard plug and therefore not integrated into the input-sources setting? Opening and closing the switchboard keyboard plug is required update the setting.

[jeremypw]

I think it best to merge this now that the corresponding switchboard plug PR is merged, and deal with any upgrade problems later.