Utils: combine/remove unused states

elementary / wingpanel-indicator-network

Wingpanel Network Indicator

GNU Lesser General Public License v2.1

26 stars 14 forks source link

Utils: combine/remove unused states #203

Closed danirabbit closed 3 years ago

danirabbit commented 3 years ago

CONNECTED_WIFI and DISCONNECTED_WIRED are never set
There doesn't appear to be any difference between FAILED_WIRED and FAILED_VPN

tintou commented 3 years ago

As an occasional VPN user, it would be useful to have a specific message with "failed to connect to VPN" as this happens after the connection to network.

danirabbit commented 3 years ago

@tintou Yeah I think there’s probably a better way to get the device type though and not conflate with state like we’re doing here. My eventual goal is to use NM.DeviceState like in Switchboard

jeremypw commented 3 years ago

@danrabbit Is it your intention that this PR should merged and Corentin's issue dealt with in a later PR?

danirabbit commented 3 years ago

@jeremypw it sounds like Corentin is looking for a new feature and not that this branch would break an existing feature. So yes I think that would be better to move towards separating device type from state as using state directly from NM