elementary / wingpanel-indicator-network

Wingpanel Network Indicator
GNU Lesser General Public License v2.1
26 stars 14 forks source link

Add airplane mode switch to popover; add middle-click tooltip #235

Closed jeremypw closed 1 year ago

jeremypw commented 3 years ago

Fixes #6 Fixes #8

Needs input on:

jeremypw commented 3 years ago

Tooltip NetworkingMiddleClickTooltip

Popover AirPlaneSwitchTop

ryonakano commented 3 years ago

I'm not familiar with UX, but I feel like the airplain switch in the popover should be placed in the top of it; the number of wireless networks is mutable, so the position of switch also may differ every time users opens the popover.

Also, the actions triggered by middle-clicking in other indicators also have a switch for that action in the top of their popovers, so placing the switch there would be consistent.

jeremypw commented 3 years ago

@ryonakano Thanks for the review! I can easily put the switch right at the top of the popover instead of right at the bottom. Anywhere else is a little more complicated.