elementary / wingpanel-indicator-network

Wingpanel Network Indicator
GNU Lesser General Public License v2.1
26 stars 14 forks source link

Use device name instead of model name for ethernet tethering #239

Closed kdwk closed 1 year ago

kdwk commented 3 years ago

Problem

Screenshot from 2021-10-19 15-34-15

The name of the model of my device is incorrect. It should be 'Apple iPad (6th generation)'. Moreover, if two devices of the same model is connected via USB and both are available for USB ethernet tethering, it would be impossible to tell which one is which.

Proposal

Display the devices' name instead of its model name, like in Files:

Screenshot from 2021-10-19 15-35-20

Prior Art (Optional)

No response

danirabbit commented 1 year ago

We're using the disambiguation from Network Manager here now, so I can confirm that it'll show as either "USB Ethernet" or "Apple Ethernet". If it would better for it to always show "iPad Ethernet" or something like that, that should be pursued upstream in Network Manager: https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/issues

Closing as "Out of scope" since device names come from Network Manager