elementary / wingpanel-indicator-network

Wingpanel Network Indicator
GNU Lesser General Public License v2.1
26 stars 14 forks source link

Use circular toggles for airplane mode and ethernet #258

Closed danirabbit closed 1 year ago

danirabbit commented 1 year ago

Fixes #152 Uses circular toggle buttons instead of modelbutton rows for airplane mode and wired items

Putting wireless here would require a significant rework, so it will have to wait for another branch

BEFORE

Screenshot from 2023-02-14 14 54 42

AFTER

With 1 ethernet port Screenshot from 2023-02-15 17 03 12@2x

With no ethernet Screenshot from 2023-02-15 08 38 54

With lots of ethernet Screenshot from 2023-02-16 12 55 30

In Greeter mode with no ethernet Screenshot from 2023-02-15 16 48 59@2x

tintou commented 1 year ago

I do wonder if we do not want to limit it to 2 circles wide with a Gtk.FlowBox?

danirabbit commented 1 year ago

@tintou I was just changing it to a flowbox since those other branches were merged ;)

Hows 3? Screenshot from 2023-02-16 12 55 30

tintou commented 1 year ago

3 looks great :smiley:

danirabbit commented 1 year ago

@tintou found a bug with removing interfaces with the flowbox. Quick re-review? :)