search

elementary / wingpanel-indicator-network

Wingpanel Network Indicator
GNU Lesser General Public License v2.1
25 stars 14 forks source link

Show VPN as a FlowBox of ToggleButtons #268

Closed danirabbit closed 1 year ago

danirabbit commented 1 year ago

Fixes #145 Fixes #212

BEFORE

Screenshot from 2023-02-18 09 58 46

AFTER

Screenshot from 2023-02-18 09 45 45

zeebok commented 1 year ago

What happens if the VPN list ends up really long? I know some providers like PIA let use a script to add their locations to NetworkManager and it will add a lot of them. Does the whole network indicator have a max size and scrollbar?

danirabbit commented 1 year ago

@zeebok currently We’re adding scrolled windows per section so there are some outstanding issues about the menu being too long on some displays and with multiple wireless cards etc. I think you’re right there should be a max height for the whole indicator, but I’m not sure that makes sense for this branch since it would touch a lot of other things.

I’ll propose another branch for that though!