elementary / wingpanel-indicator-notifications

Wingpanel Notifications Indicator
GNU Lesser General Public License v2.1
24 stars 11 forks source link

Hide notifications when the icon is clicked #64

Open sprite-1 opened 5 years ago

sprite-1 commented 5 years ago

When the bell icon is clicked, I wish it would hide all the open notifications because they just get in the way. I don't think it's necessary to show said notifications again after the notification menu is closed either because the user already demonstrated they know where to see them.

To clarify I'm talking about situations like this image_2019-02-17_06-16-49

As you can see, the notification popups cover the notification menu so I think when the notification menu is opened, these popups should be hidden. The notifications would still be accessible to the user from the menu so I think it's okay to hide the popups after the user has manually opened the menu. This will only apply to current notifications Subsequent notifications should still do the popups and so on and so forth.

peteruithoven commented 5 years ago

I don't like this idea. I frequently leave notifications because I want to deal with them on a later date. (Even more on my Android phone) Clearing the list is already possible by clicking the Clear all notifications button?

the user already demonstrated they know where to see them.

Could you clarify what you mean here?

sprite-1 commented 5 years ago

I don't mean clearing the notifications on this list image

I mean't hiding the floating notifications because when the above menu is opened, those floating notifications cover it.

I updated my original post with a demo

peteruithoven commented 5 years ago

Thanks for the clarification. I like your idea. I guess this would also be the only way to clear all floating notifications?

sprite-1 commented 5 years ago

I was careful not to say "clear" because I don't actually want to make it have the same behavior as clicking the (X) button on the notification which dismisses it. I just wanted them to be hidden (i.e not shown on the desktop but can still be found in the notifications menu for interaction later).

Maybe that's another area of topic in itself but it's still unclear to me what the (X) button in floating notifications do. Sometimes they dismiss it completely, sometimes the notification stays on the menu.

janxkoci commented 4 years ago

it's still unclear to me what the (X) button in floating notifications do. Sometimes they dismiss it completely, sometimes the notification stays on the menu

I think they should show up in the indicator but some fail to do so. Or they should be cleared and again, some fail to do so. Either way, it's buggy.

danirabbit commented 4 years ago

So what we need here is to create some kind of DBus API so that the notification server can find out if the notifications indicator is open.

We also have reports about not having other notifications overlapping indicators as well. So perhaps we should just make this a feature of the panel itself and have it apply for all indicators packed into the end portion of the panel.

@cassidyjames thoughts on that?

cassidyjames commented 4 years ago

@danrabbit yeah that seems more sane; just hide notifications (possibly pausing any of their timeouts) while end-side indicators are open.