search

elementary / wingpanel-indicator-power

Wingpanel Power Indicator
GNU General Public License v3.0
24 stars 15 forks source link

Battery charged notifcation #215

Closed andirsun closed 2 years ago

andirsun commented 3 years ago

fixes #217

Screenshot from 2021-08-20 16-26-34

tomaswarynyca commented 3 years ago

Hi @andirsun, I think it's a great idea. I would remove the symbolic, use "battery-full-charged".

When testing it I noticed a problem, in the notification it does not show the icon. Is it related to the PR code? Screenshot from 2021-08-21 20-32-59 Screenshot from 2021-08-21 20-33-07

4jNsY6fCVqZv commented 3 years ago

Unplugging the device now can extend battery health

Wondering from a purely technical point of view: How far should a battery be charged or not yet be discharged in order to actually extend the health of a battery?

cassidyjames commented 3 years ago

@4jNsY6fCVqZv I don't think there's a single magic number, but I frequently hear 80% being a good figure for when to unplug to maximize long-term battery health. Charging has a greater amount of wear the higher the battery is charged, so it's a trade-off of convenience.

I think we could extend this feature in the future with more smarts around a percentage to notify, but this is a good start.

danirabbit commented 3 years ago

I wonder if we should build in a setting to disable this notification from the start. I can see this being similar to the network available notification where it's kind of useful in terms of onboarding, but kind of annoying to see every time