elementary / wingpanel-indicator-power

Wingpanel Power Indicator
GNU General Public License v3.0
26 stars 15 forks source link

Implement Power Profile management #221

Closed SubhadeepJasu closed 3 years ago

SubhadeepJasu commented 3 years ago
SubhadeepJasu commented 3 years ago

Screenshot with placeholder icons: image

cassidyjames commented 3 years ago

@SubhadeepJasu I see #220 is also already open. I haven't dug into the code exactly, but the design of #220 is what I'd lean toward since we don't have icons and the labels will be more clear to start. We can always revisit the design if needed, but in this case I think the labels are more clear. Would it make sense for you to review #220 in case there's anything that differs/you discovered while implementing this so we can standardize on one PR?

SubhadeepJasu commented 3 years ago

Actually it's my bad. I should have checked before working on this branch and making a pull request directly.On #220 I would only check or on thing and that is having it update the selection on popover open. I am closing this right now.