search

elementary / wingpanel-indicator-sound

Wingpanel Sound Indicator
Other
34 stars 24 forks source link

Wingpanel indicator sometimes shows "Not Playing" even when playing a track #266

Open jeremypw opened 8 months ago

jeremypw commented 8 months ago

What Happened?

Played a track in Music. Opened wingpanel sound indicator. Noted the track appeared correctly named but marked "Not playing"

Steps to Reproduce

  1. Play a track in Music
  2. Open Wingpanel sound indicator
  3. Note "Not playing"

Expected Behavior

The sound indicator should correctly determine the playing status in Music. The indicator correctly shows the playing status in the other elementary media app Videos.

(Strangely, with RhythmBox the secondary label contains the Artist name not the playing status)

OS Version

7.x (Horus)

Software Version

Latest release (I have run all updates)

Log Output

No response

Hardware Info

No response

Marukesu commented 8 months ago

The "Not Playing" label is a fallback label for when the application doesn't set a xesam:artist tag in the org.mpris.MediaPlayer2.Player.Metadata property.

looking at the indicator code, it don't update the label when the play/pause state changes, so it keeps "Not Playing" until there's a metadata change.

jeremypw commented 8 months ago

@Marukesu Thanks for the analysis - sounds easy enough to fix. The simplest fix would be to change the fallback to something like "Unknown Artist" I guess.

jeremypw commented 8 months ago

There is still an issue (in Wingpanel indicator) in that Music displays the Artist name even when the Wingpanel shows "Not playing"?