Fails to build with mutter 3.34

[worldofpeace]

Prerequisites

• [x] I have searched open and closed issues for duplicates.

Describe the bug

This is the log I get

[18/37] Compiling C object 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_FocusManager.c.o'.'.roundManager.vala ../src/Services/IndicatorSorter.vala ../src/Services/PopoverManager.vala ../src/Widgets/IndicatorEntry.vala ../src/Widgets/IndicatorMenuBar.vala ../src/Widgets/IndicatorPopover.vala ../src/Widgets/MenuBar.vala ../src/Widgets/Panel.vala ../src/Widgets/StyleClass.vala lib/wingpanel-2.0.vapi.
FAILED: wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_FocusManager.c.o
/nix/store/1wb31gzrjw055xl6d3igzj1gnajzlwbk-gcc-wrapper-9.2.0/bin/cc -Iwingpanel-interface/fb1d034@@wingpanel-interface@sha -Iwingpanel-interface -I../wingpanel-interface -I/nix/store/0pa1fkvg6wfybvbr5v5n2ym4zc63fnvb-gala-unstable-2020-03-26/include/gala -I/nix/store/w9xdfwh0jq4vnqmjg0afas6zbcyg4bmm-gtk+3-3.24.14-dev/include/gtk-3.0 -I/nix/store/ywqwl19b9x5a3i8z3j0n0vkk3w529hng-atk-2.34.1-dev/include/atk-1.0 -I/nix/store/5mj5kkymfnkfdw6956n8nwxbxharcv8d-glib-2.62.5-dev/include/gio-unix-2.0 -I/nix/store/5mj5kkymfnkfdw6956n8nwxbxharcv8d-glib-2.62.5-dev/include -I/nix/store/5mj5kkymfnkfdw6956n8nwxbxharcv8d-glib-2.62.5-dev/include/glib-2.0 -I/nix/store/56rgn6k5vc151lhxwl8ghnbbk80yghj3-glib-2.62.5/lib/glib-2.0/include -I/nix/store/lp12b7x75m7r2jlar6ldvj3n9wjy6ybc-cairo-1.16.0-dev/include/cairo -I/nix/store/wn7j6ssmqsz56vcz7c6y4m1w0dx1p521-freetype-2.10.1-dev/include/freetype2 -I/nix/store/wn7j6ssmqsz56vcz7c6y4m1w0dx1p521-freetype-2.10.1-dev/include -I/nix/store/x7zbqbyfa8zcbdv8vc72i7krxzlw8qhb-xorgproto-2019.1/include -I/nix/store/d0ybsm1355dl3idvpqnq16kxw0352qjh-libX11-1.6.8-dev/include -I/nix/store/wdfiw6xykwpbzffqjyc8ryz9yjpq0fy4-mesa-19.3.3-dev/include -I/nix/store/x9ywfnhqx2232hy6hbmmvg9cjzzxnhrc-libglvnd-1.2.0-dev/include -I/nix/store/z6g3bmlpdfk4c5xsx6j6bl7mx73fqdvh-gdk-pixbuf-2.40.0-dev/include/gdk-pixbuf-2.0 -I/nix/store/slmsmbyfgf1rqj9rp6s1y33cqaz8q203-gsettings-desktop-schemas-3.34.0/include/gsettings-desktop-schemas -I/nix/store/0wm8v44d672jskzc1dcs2pw2081w70jr-libXfixes-5.0.3-dev/include -I/nix/store/yhjzcyqkc75vkw9z0fmka20lw8zrkwr0-libXi-1.7.10-dev/include -I/nix/store/mjxl004m51whvlakx4j40z1mcp8qkj31-pango-1.44.7-dev/include/pango-1.0 -I/nix/store/jrzqqv25d07i9har1g7vl8v5z9swxlh0-harfbuzz-2.6.4-dev/include/harfbuzz -I/nix/store/2fxkfprccnc8r62k0arzjlmj4k37ifk2-wayland-1.18.0/include -I/nix/store/z0hgbpd8g2d33s3hkh1lrjb7yncgjwvn-json-glib-1.4.4-dev/include/json-glib-1.0 -I/nix/store/cfwgvnp8msmi3136is46frdgy465hknb-mutter-3.34.4-dev/include/mutter-5 -I/nix/store/cfwgvnp8msmi3136is46frdgy465hknb-mutter-3.34.4-dev/include/mutter-5/clutter -I/nix/store/cfwgvnp8msmi3136is46frdgy465hknb-mutter-3.34.4-dev/include/mutter-5/cogl -I/nix/store/byjdlqxdnqmk9m85nnc2kq8jpglz2l54-libcap-ng-0.7.10/include -I/nix/store/nppwnf9mjsgab7bf9hdwa2vk64mqj5f8-granite-5.3.0/include/granite -I/nix/store/wf4syskxmqhvv39jrnlzfcy4rhhrhijp-libgee-0.20.3-dev/include/gee-0.8 -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -w '-DGETTEXT_PACKAGE="wingpanel"' '-DG_LOG_DOMAIN="wingpanel"' -fPIC -DCLUTTER_ENABLE_COMPOSITOR_API -DCLUTTER_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_API -DCOGL_ENABLE_EXPERIMENTAL_2_0_API -MD -MQ 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_FocusManager.c.o' -MF 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_FocusManager.c.o.d' -o 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_FocusManager.c.o' -c 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/FocusManager.c'
In file included from wingpanel-interface/fb1d034@@wingpanel-interface@sha/FocusManager.c:26:
/nix/store/cfwgvnp8msmi3136is46frdgy465hknb-mutter-3.34.4-dev/include/mutter-5/meta/meta-workspace-manager.h:73:56: error: unknown type name 'MetaDisplayCorner'; did you mean 'MetaDisplay'?
   73 |                                                        MetaDisplayCorner     starting_corner,
      |                                                        ^~~~~~~~~~~~~~~~~
      |                                                        MetaDisplay
[20/37] Compiling Vala source ../src/PanelWindow.vala ../src/SessionManager.vala ../src/Wingpanel.vala ../src/Services/BackgroundManager.vala ../src/Services/IndicatorSorter.vala ../src/Services/PopoverManager.vala ../src/Widgets/IndicatorEntry.vala ../src/Widgets/IndicatorMenuBar.vala ../src/Widgets/IndicatorPopover.vala ../src/Widgets/MenuBar.vala ../src/Widgets/Panel.vala ../src/Widgets/StyleClass.vala lib/wingpanel-2.0.vapi.
../src/Services/IndicatorSorter.vala:79.13-79.60: warning: Gee.Map.contains is deprecated. Use Map.has_key
../src/PanelWindow.vala:45.26-45.51: warning: Gdk.Screen.get_primary_monitor has been deprecated since 3.22
../src/PanelWindow.vala:107.26-107.51: warning: Gdk.Screen.get_primary_monitor has been deprecated since 3.22
Compilation succeeded - 3 warning(s)
[23/37] Compiling C object 'wingpanel-interface/fb1d034@@wingpanel-interface@sha/meson-generated_Utils.c.o'.ger.c.o'.
ninja: build stopped: subcommand failed.
builder for '/nix/store/ynhrjpzlc318byxrbhimjig4fxb2x22v-wingpanel-unstable-2020-03-26.drv' failed with exit code 1
error: build of '/nix/store/ynhrjpzlc318byxrbhimjig4fxb2x22v-wingpanel-unstable-2020-03-26.drv' failed

It builds on https://github.com/elementary/wingpanel/commit/b3e4f96183eb9245d28fdc466616902446b22e60 but not 0d7c5027e9b441ea57287cfdae267b403dc59279.

The most likely bad commits are: 462e61a78903a74b23dde7d7e2558a0659d311c5 68fe50ec31559029096d4e6676a6d922d89ccebd

cc @davidmhewitt

To Reproduce

Build wingpanel with mutter 3.34

Expected behavior

Succeeds

Platform Information

OS: NixOS OS Version: 20.09 git We're using a GNOME 3.34 stack at the moment.

• [x] I'm using the latest version from git that I've manually compiled
• [ ] I'm using the latest released stable version

[tintou]

You need to either patch 3.34 to contain this commit https://gitlab.gnome.org/GNOME/mutter/-/commit/9d390ee49fb1f6300336e82ae94cc8061c6bae12?merge_request_iid=1025 or use 3.36

[worldofpeace]

@tintou Thanks, I'll add that to our stable channels.