search

elementary / wingpanel

Stylish top panel that holds indicators and spawns an application launcher
https://elementary.io
GNU General Public License v3.0
137 stars 46 forks source link

App indicators appear in between system indicators #366

Closed pongloongyeat closed 3 years ago

pongloongyeat commented 3 years ago

What Happened

App indicators appear in between system indicators. image

Expected Behavior

Although app indicators aren't supported, there should be at least some check to ensure that system indicators appear on the far right with any other custom indicator appearing to the left of system indicators.

Steps to Reproduce

  1. Turn on night light.
  2. Install random app indicator (wingpanel-indicator-template for example).
danirabbit commented 3 years ago

There's no way to ensure this since as far as the panel is concerned there's no such distinction between types of indicators. There is only indicators

davidmhewitt commented 3 years ago

Sounds like we just need to add the nightlight indicator here, along with any other new ones we've missed: https://github.com/elementary/wingpanel/blob/ef0908ea25f541f7e4944819e473f96d972ef048/src/Services/IndicatorSorter.vala#L33-L45

pongloongyeat commented 3 years ago

Huh never knew there was a printer indicator and I do wonder what the sync indicator is :open_mouth:

Here's the list of indicators that have not yet been added for your convenience:

davidmhewitt commented 3 years ago

This is now resolved, thanks again @pongloongyeat !