elementdavv / internet_archive_downloader

A chrome/firefox extension that download books from Internet Archive(archive.org) and HathiTrust Digital Library (hathitrust.org)
GNU Affero General Public License v3.0
324 stars 26 forks source link

Download failed #20

Open logion2000 opened 1 year ago

logion2000 commented 1 year ago

I used Firefox. I don't why the download failed. I have tried several times. Also, when I used MS Edge, the Quality button does not show up. See the last screenshot below.

image image

image

elementdavv commented 1 year ago

About "cross origin request blocked" error on Firefox, I have tested the extension on every platforms I can find such as Windows/Mac/Ubuntu/Fedora/Arch, and it works out of the box for every fresh platform installations. But there are persons who report the error as you. May be other installed applications or system security policies have impacted the Firefox functions, I have no way to debug it without the environments that lead to the error. For your situation, you can make some tries, such as disable other extensions, disable firewall and other security settings, or create and use a new Firefox profile. If every effort fails, then I suggest you to change to Chrome family browsers.

As for the no Quality button error in Edge, it is so ridiculous. The two buttons should be both showing or not showing. Can you take a look at the developer console page, may be some errors happened.

logion2000 commented 1 year ago

Here is the screenshot of the developer console. Hopefully you can find what went wrong. image

image

elementdavv commented 1 year ago

Here is the screenshot of the developer console. Hopefully you can find what went wrong.

The messages on your screenshot do not related to the extension. Do you install the extension from Edge addons repository? It is not up to date and has only one Download button. You should install the latest version from Chrome webstore.

asheroto commented 1 year ago

Having the same issue for some reason. Using the latest version of Chrome.

image

Just installed the Chrome extension from the web store.

Version 0.6.3

Click 'Download' a few times and got this...

image

Would the size matter? Trying to download a nearly 400 page PDF on a 1 Gbps connection as a test.

Clicked Borrow then Download.

elementdavv commented 1 year ago

Having the same issue for some reason. Using the latest version of Chrome. Just installed the Chrome extension from the web store. Version 0.6.3 Click 'Download' a few times and got this... Would the size matter? Trying to download a nearly 400 page PDF on a 1 Gbps connection as a test.

You are using Chrome with the extension v0.6.3 ? So how do you operate to get a request to elementdavv.github.io ? This domain is only used by the extension for Firefox. The extension for Chrome will work without elementdavv.github.io.

For the File download blocked issue, please provide a complete messages from the console page.

The file size does not matter. It can download a PDF file of several thousand pages and several GB size.

asheroto commented 1 year ago

I was mistaken when I said I used Chrome. I am using Brave, which is Chromium-based. I found the problem and it's not the extension's fault! With Brave, it has built-in ad-blocking and other security items that help protect users on the web. When Brave Shields are on, the extension fails, but if you turn them off like so, the extension works fine. Sorry about that! 😳

image

So heads up, if you have Brave users they need to turn off the Brave shields.

Working with Brave Shields Disabled

![image](https://github.com/elementdavv/internet_archive_downloader/assets/49938263/329c799b-02da-45ce-b74b-648c220a1ccf)

Not Working with Brave Shields Enabled

![image](https://github.com/elementdavv/internet_archive_downloader/assets/49938263/1eeaba60-afea-408d-ae50-58dd037b029c)


If it's not working with Edge or other browsers like the OP mentioned, perhaps it is due to some security, blocking fingerprinting or third-party cookies similar to what Brave shields does...

image

Hope that helps! As for me, I'm set, but other users may have a separate issue if they've disabled some of these extra security items in their browser.

elementdavv commented 1 year ago

Hope that helps! As for me, I'm set, but other users may have a separate issue if they've disabled some of these extra security items in their browser.

Yes. You are right. And you can simply enable item 'File System Access API' in 'brave://flags' page without touching Shields.

asheroto commented 1 year ago

Gotcha. But that would enable it for all sites, right? The shields only affect the individual site when you toggle it...

gmy77 commented 11 months ago

Edge, download PDF file but zero byte content... and i try the various descripted methods.

elementdavv commented 11 months ago

Edge, download PDF file but zero byte content... and i try the various descripted methods.

What is the pdf url? Did you try Chrome?

eelalzep commented 8 months ago

I'm using Firefox Android and downloading keeps failing, and when i decide to go in private mode it pops up thisScreenshot_2024-03-22-08-02-47-520_org.mozilla.firefox.jpg