elementdavv / internet_archive_downloader

A chrome/firefox extension that download books from Internet Archive(archive.org) and HathiTrust Digital Library (hathitrust.org)
GNU Affero General Public License v3.0
324 stars 26 forks source link

Error message in Brave Browser (works in Edge) #6

Closed mrg9999 closed 1 year ago

mrg9999 commented 1 year ago

Until today I'd never used Edge, favoring Firefox or Brave for a Chrome like experience. I've removed Chrome from my Windows PC.

Tried this in Brave today and the error message was archive.org says ReferenceError: showSaveFilePicker is not defined Please contact the developer.

Brave Version - Version 1.51.118 Chromium: 113.0.5672.126 (Official Build) (64-bit)

elementdavv commented 1 year ago

showSaveFilePicker is disabled by default in Brave. Try this Navigate to brave://flags In the search box type file-system-access-api Change the File System API item's status to Enabled

mrg9999 commented 1 year ago

showSaveFilePicker is disabled by default in Brave. Try this Navigate to brave://flags In the search box type file-system-access-api Change the File System API item's status to Enabled

Thanks I tried that, restarted and it gives me another error message archive.org says TypeError: Failed to fetch Please contact the developer.

Edge - Works Version 113.0.1774.57 (Official build) (64-bit)

Google Chrome - Works Version 114.0.5735.91 (Official Build) (64-bit)

Chromium - Not working, not even loading Version 92.0.4515.98 (Official Build) Built on Raspbian , running on Raspbian 10 (32-bit)

Brave Raspian 64bit same error, tried to download then type error

Test page https://archive.org/details/carvehernamewith0000rjmi

elementdavv commented 1 year ago

For Brave to work, besides changing that config, it is also required to disable and enable the extension once every time you launch Brave. It is a Brave bug.