elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.
https://elementor.com/
GNU General Public License v3.0
6.55k stars 1.41k forks source link

📚 🧩 Custom Lightbox implementation no longer works since Elementor update 3.5.5. #17708

Open Nazrinn opened 2 years ago

Nazrinn commented 2 years ago

Prerequisites

What problem is your feature request going to solve? Please describe.

Hi there!

I am managing a real estate website which use custom lightbox a lot. One of the button on the listings page can show a my.matterport.com embed (which shows a 3D plan of the house).

However, since update update Elementor 3.5.5 (Fix: Hardened the Lightbox action module sanitization to prevent potential security issues), I am no longer able to display this embed in my lightbox.

Click on the "3D tour" button you can find on some of the listings to test.

Here is the PHP code that goes on the "3D tour" button. It is the same for both the broken and working demo:

$threeD_tour_button =
          '<div class="elementor-button small ghost clickable has-icon" data-elementor-lightbox="{&quot;type&quot;:&quot;video&quot;,&quot;videoType&quot;:&quot;youtube&quot;,&quot;url&quot;:&quot;'.$threeD_tour.'&play=1&qs=1&quot;,&quot;modalOptions&quot;:{&quot;id&quot;:&quot;elementor-lightbox-6d4c51e&quot;,&quot;entranceAnimation&quot;:&quot;&quot;,&quot;entranceAnimation_tablet&quot;:&quot;&quot;,&quot;entranceAnimation_mobile&quot;:&quot;&quot;,&quot;videoAspectRatio&quot;:&quot;169&quot;}}">
            '.icon('cube').'
            3D Tour
          </div>';

Note that a matterport embed URL looks something like this: https://my.matterport.com/show/?m=apiNoX4xT3k. Please refer to Matterport iframe documentation for more info.

Describe the solution you'd like

Please have an "at risk" mode when using the lightbox API so people with me can trigger a lightbox with whatever embed they want in it, OR include my.matterport.com embed into allowed embed types.

This is very important and cannot update Elementor so long as I cannot do this. Thank you!

Describe alternatives you've considered

Integrating a completely separate lightbox script just for that one button. =(

Additional context

Related to 292fc49e0f979bd52d838f0326d1faaebfa59f5e.

KingGrizzly commented 2 years ago

My sites are impacted. Vimeo lightboxes for private videos with white-listed domain don't work. They do work in media carousel or in regular video widget if DailyMotion is selected.

vls-dev commented 2 years ago

+1 on needing the ability to display Matterport iframes within the lightbox.

Nazrinn commented 1 year ago

I will need to display Sketchbab embed in the lightbox soon too. Any plan on making this possible, Elementor team?

Nazrinn commented 1 month ago

Actually has this issue been solved? Is it possible to display embedded content in any lightbox using a button trigger now? I'm thinking about the new off-canvas function.