🐞 Bug report: Video Playlist Widget causing Mixed Content errors on https

JasonYteam commented 2 years ago

Prerequisites

[X] I have searched for similar issues in both open and closed tickets and cannot find a duplicate.
[X] The issue still exists against the latest stable version of Elementor.

Description

When I add the Video Playlist Widget to a page on a secure website (using https), the browser shows the site as not secure due to Mixed Content.

The culprits are the thumbnails generated by the Video Playlist Widget in the tabs. The url used for the images uses an http protocol instead of https. This happens for the default thumbnails as well as the generated thumbnails when pulling the data from the video.

Steps to reproduce

Ensure that the website has an SSL certificate installed and the URL includes https://
Install Elementor (3.6.6) and Elementor Pro (3.7.1)
Edit a page with Elementor.
Add a Video Playlist widget
You can leave it as is or you can add a videos to the tabs and click the Get Video Data button for each.
Update the page.
Run the page on the front end. The Lock in the browser will show as not secure.

Isolating the problem

[X] This bug happens with only Elementor plugin active (and Elementor Pro).
[X] This bug happens with a Blank WordPress theme active (Hello theme).
[X] I can reproduce this bug consistently using the steps above.

System Info

== Server Environment == Operating System: Linux Software: Apache MySQL version: MariaDB Server v10.3.27 PHP Version: 7.4.25 PHP Memory Limit: 32M PHP Max Input Vars: 3000 PHP Max Post Size: 40M GD Installed: Yes ZIP Installed: Yes Write Permissions: All right Elementor Library: Connected

== WordPress Environment == Version: 5.9.3 Site URL: https://www.experiencersupport.org Home URL: https://www.experiencersupport.org WP Multisite: No Max Upload Size: 20 MB Memory limit: 256M Max Memory limit: 256M Permalink Structure: /%category%/%postname% Language: en-US Timezone: America/Toronto Admin Email: tesa@collaborativehaushosting.com Debug Mode: Inactive

== Theme == Name: Hello Elementor Child Version: 1.0.1 Author: Elementor Team Child Theme: Yes Parent Theme Name: Hello Elementor Parent Theme Version: 2.5.0 Parent Theme Author: Elementor Team

== User == Role: administrator WP Profile lang: en_US User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:101.0) Gecko/20100101 Firefox/101.0

== Active Plugins == Admin Menu Editor Version: 1.10.2 Author: Janis Elsts

Advanced Custom Fields: Timezone
    Version: 1.0.0
    Author: Beau Watson

Advanced Custom Fields PRO
    Version: 5.12.2
    Author: Delicious Brains

Advanced Editor Tools (previously TinyMCE Advanced)
    Version: 5.6.0
    Author: Automattic

All in One SEO
    Version: 4.2.1.1
    Author: All in One SEO Team

Black Studio TinyMCE Widget
    Version: 2.7.0
    Author: Black Studio

Classic Editor
    Version: 1.6.2
    Author: WordPress Contributors

Classic Widgets
    Version: 0.3
    Author: WordPress Contributors

Cool Timeline Pro
    Version: 4.2
    Author: Cool Plugins

Ele Custom Skin
    Version: 3.1.6
    Author: Dudaster.com

Elementor
    Version: 3.6.6
    Author: Elementor.com

Elementor Pro
    Version: 3.7.1
    Author: Elementor.com

Embed Plus Plugin for YouTube
    Version: 14.1.1
    Author: Embed Plus for YouTube Team

EventON
    Version: 4.0.6
    Author: AshanJay

EventON - Event Lists Ext
    Version: 0.22
    Author: Ashan Jay

EventON - Full cal
    Version: 2.0.3
    Author: Ashan Jay

EWWW Image Optimizer
    Version: 6.5.2
    Author: Exactly WWW

Gravity Forms
    Version: 2.6.3
    Author: Gravity Forms

Gravity Forms Mailchimp Add-On
    Version: 5.1
    Author: Gravity Forms

GTranslate
    Version: 2.9.12
    Author: Translate AI Multilingual Solutions

PDFjs Viewer - Embed PDFs
    Version: 2.1.7
    Author: <a href="http://byterevel.com/">Ben Lawson</a>, <a href="https://www.twistermc.com/">Thomas McMahon</a>

PDF viewer for Elementor
    Version: 2.9.3
    Author: RedLettuce Plugins

Simple Page Ordering
    Version: 2.4.0
    Author: Jake Goldman, 10up

Site Kit by Google
    Version: 1.75.0
    Author: Google

Stop WP Emails Going to Spam
    Version: 2.0.5
    Author: Alan Fuller

UpdraftPlus - Backup/Restore
    Version: 1.22.12
    Author: UpdraftPlus.Com, DavidAnderson

Woody code snippets (PHP snippets | Insert PHP)
    Version: 2.4.6
    Author: Creative Motion, Will Bontrager Software, LLC <will@willmaster.com>

WP All Export - ACF Export Add-On Pro
    Version: 1.0.3
    Author: Soflyy

WP All Export Pro
    Version: 1.7.6
    Author: Soflyy

wpForo
    Version: 1.9.9.1
    Author: gVectors Team

WP Google Map Pro
    Version: 5.3.2
    Author: flippercode

Yoast Duplicate Post
    Version: 4.4
    Author: Enrico Battocchi & Team Yoast

YourChannel
    Version: 1.1.7
    Author: Plugin Builders

== Elementor Experiments == Optimized DOM Output: Active by default Improved Asset Loading: Active by default Improved CSS Loading: Active by default Inline Font Icons: Inactive by default Accessibility Improvements: Active by default Import Export Template Kit: Active by default Additional Custom Breakpoints: Active by default Hide native WordPress widgets from search results: Active by default : Inactive by default Flexbox Container: Inactive by default Default to New Theme Builder: Active by default Hello Theme Header & Footer: Active by default Landing Pages: Active by default Color Sampler: Active by default Favorite Widgets: Active by default Admin Top Bar: Active by default Page Transitions: Active by default Notes: Active by default Form Submissions: Active by default Scroll Snap: Active by default

== Elementor - Compatibility Tag ==

Ele Custom Skin: Compatible
Elementor Pro: Compatible
PDF viewer for Elementor: Compatibility not specified

== Elementor Pro - Compatibility Tag ==

Ele Custom Skin: Compatible

JasonYteam commented 2 years ago

I'm able to fix the issue by updating the code in 3 places to change http:// to https://

/elementor-pro/modules/video-playlist/widgets/video-playlist.php on lines 315, 322, 329
/elementor-pro/assets/js/video-playlist.abunchofcharacters.bundle.js on line 1271
/elementor-pro/assets/js/video-playlist.abunchofcharacters.bundle.min.js on line 2 at column 20743

rami-elementor commented 2 years ago

Hi @JasonYteam ,

Thank you for taking the time to report this bug.

I fixed this issue. You will see it in the coming Elementor Pro 3.8 release.

avivu commented 1 year ago

This issue has been resolved in Elementor Pro v3.8.0

Feel free to update

Thanks!

nilay-automatesmb commented 9 months ago

Where can we find the v 3.8.0? In wordpress it displays that the latest version available is 3.18.3. Same is mentioned in the changelogs as of jan 2024: https://elementor.com/pro/changelog/

Zach-ah commented 9 months ago

@rami-elementor I think the issue is reoccuring. Please check.

elementor / elementor