elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.
https://elementor.com/
GNU General Public License v3.0
6.58k stars 1.42k forks source link

⛔ Button icon media popup does not show the currently selected icon #25714

Closed jamieburchell closed 5 months ago

jamieburchell commented 6 months ago

Prerequisites

Description

The media selector which pops up after clicking "Upload SVG" on the button widget does not show the current icon as selected.

Screencast

Steps to reproduce

  1. Add a new button and upload an SVG
  2. Click the upload SVG button again - the media selector does not show the currently selected SVG

Expected behavior

  1. Add a new button and upload an SVG
  2. Click the upload SVG button again - current icon should be selected

Isolating the problem

Elementor System Info

Click to reveal ````txt == Server Environment == Operating System: Linux Software: Apache/2.4.52 (Ubuntu) MySQL version: Ubuntu 22.04 v10.6.16 PHP Version: 8.1.27 PHP Memory Limit: 256M PHP Max Input Vars: 10000 PHP Max Post Size: 64M GD Installed: Yes ZIP Installed: Yes Write Permissions: All right Elementor Library: Connected == WordPress Environment == Version: 6.5 Site URL: https://example.local.test/wp Home URL: https://example.local.test WP Multisite: No Max Upload Size: 16 MB Memory limit: 40M Max Memory limit: 256M Permalink Structure: /news/%postname%/ Language: en_GB Timezone: Europe/London Debug Mode: Active == Theme == Name: Hello Elementor Version: 3.0.1 Author: Elementor Team Child Theme: No == User == Role: administrator WP Profile lang: en-GB User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36 == Active Plugins == Elementor Version: 3.20.3 Author: Elementor.com Elementor Pro Version: 3.20.2 Author: Elementor.com == Must-Use Plugins == Bedrock Autoloader Version: 1.0.3 Author: Roots Disable status tests Version: 1.0.0 Author: Roots Register Theme Directory Version: 1.0.0 Author: Roots == Features == Custom Fonts: 1 Custom Icons: 0 == Integrations == recaptcha_v3: Active == Elementor Experiments == Improved Asset Loading: Active Improved CSS Loading: Active Inline Font Icons: Active Additional Custom Breakpoints: Inactive admin_menu_rearrangement: Inactive by default Flexbox Container: Active Upgrade Swiper Library: Active Grid Container: Inactive Default to New Theme Builder: Active Hello Theme Header & Footer: Inactive Editor Top Bar: Inactive Optimized Gutenberg Loading: Inactive Build with AI: Inactive Landing Pages: Inactive Nested Elements: Inactive Lazy Load Background Images: Inactive Optimize Image Loading: Active Notes: Inactive Display Conditions: Inactive Form Submissions: Active Menu: Inactive Taxonomy Filter: Inactive == Log == Log: showing 20 of 372024-03-04 15:25:37 [info] Elementor/Upgrades - _on_each_version Start 2024-03-04 15:25:37 [info] Elementor/Upgrades - _on_each_version Finished 2024-03-04 15:25:37 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor', 'from' => '3.19.3', 'to' => '3.19.4', )] 2024-03-04 15:30:25 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.12.14', 'to' => '2.13.2', )] 2024-03-04 15:31:29 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.12.14', 'to' => '2.13.2', )] 2024-03-11 08:45:31 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.13.2', 'to' => '2.13.4', )] 2024-03-11 08:46:11 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.13.2', 'to' => '2.13.4', )] 2024-03-11 08:46:13 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.13.2', 'to' => '2.13.4', )] 2024-03-18 09:26:47 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.13.4', 'to' => '2.13.5', )] 2024-04-04 11:13:09 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Dynamic.ooo - Dynamic Content for Elementor', 'from' => '2.13.5', 'to' => '2.13.7', )] 2024-04-04 11:13:46 [info] Update DB has been started [array ( 'plugin' => 'Elementor', 'from' => '3.19.4', 'to' => '3.20.3', )] 2024-04-04 11:13:46 [info] elementor::elementor_updater Started 2024-04-04 11:13:46 [info] Elementor/Upgrades - _on_each_version Start 2024-04-04 11:13:46 [info] Elementor/Upgrades - _on_each_version Finished 2024-04-04 11:13:46 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor', 'from' => '3.19.4', 'to' => '3.20.3', )] 2024-04-04 11:13:50 [info] Update DB has been started [array ( 'plugin' => 'Elementor Pro', 'from' => '3.19.3', 'to' => '3.20.2', )] 2024-04-04 11:13:50 [info] elementor-pro::elementor_pro_updater Started 2024-04-04 11:13:50 [info] Elementor Pro/Upgrades - _on_each_version Start 2024-04-04 11:13:50 [info] Elementor Pro/Upgrades - _on_each_version Finished 2024-04-04 11:13:50 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor Pro', 'from' => '3.19.3', 'to' => '3.20.2', )] PHP: showing 3 of 3PHP: 2024-02-20 10:29:31 [warning X 1][../plugins/elementor-pro/modules/assets-manager/asset-types/fonts-manager.php::252] Undefined array key "editor_post_id" [array ( 'trace' => ' #0: Elementor\Core\Logger\Manager -> shutdown() ', )] PHP: 2024-04-09 11:58:17 [warning X 44][../plugins/elementor-pro/modules/dynamic-tags/tags/site-logo.php::32] Trying to access array offset on value of type bool [array ( 'trace' => ' #0: Elementor\Core\Logger\Manager -> shutdown() ', )] PHP: 2024-04-12 10:35:11 [warning X 2][../plugins/elementor-pro/modules/posts/skins/skin-content-base.php::271] Attempt to read property "ID" on null [array ( 'trace' => ' #0: Elementor\Core\Logger\Manager -> shutdown() ', )] JS: showing 2 of 2JS: 2024-02-20 10:29:30 [error X 1][../wp-admin/post.php?post=5565&action=elementor&active-document=5:6:39] Cannot read properties of undefined (reading 'needHelpUrl') JS: 2024-04-09 10:58:36 [error X 9][../plugins/elementor/assets/js/ai.min.js?ver=3.20.3:3:7564] ReactUtils is not defined == Elementor - Compatibility Tag == Elementor Pro: Compatible == Elementor Pro - Compatibility Tag == ````

Agreement

nicholaszein commented 5 months ago

Hi Jamie,

I see this isn't the expected behavior, however, Elementor does not control how the WordPress Media Library behaves, it only uses the default Media Library API.

This is something that is not exclusive to Elementor. This happens when you try to edit a Featured Image for example. This is something that is caused by WordPress itself. Therefore, it's not an Elementor bug. I hope you can understand.

Kind regards