Fix: CSS fails “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights - Githubissues

elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.

https://elementor.com/

GNU General Public License v3.0

6.42k stars 1.39k forks source link

Fix: CSS fails “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights #27202

Open 2aragorn opened 2 weeks ago

2aragorn commented 2 weeks ago

PR Checklist

[x] The commit message follows our guidelines: https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Fix failed “Ensure text remains visible during webfont load” audit by Google’s PageSpeed Insights

Description

An explanation of what is done in this PR

Added "font-display: swap;" to relevant CSS classes.

Test instructions

This PR can be tested by following these steps:

Use Google PageSpeed to analyze a website using Elementor. (https://pagespeed.web.dev/)
Check the "Performance" tab
Check the sources of the "Ensure text remains visible during webfont load" error
One of the sources will be /wp-content/plugins/elementor/assets/lib/eicons/css/elementor-icons.css

Quality assurance

[x] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended
[x] Docs have been added / updated (for bug fixes / features)

Fixes #

CLAassistant commented 2 weeks ago

All committers have signed the CLA.