fix: check for elementor.settings.page in isScrollSnapActive [ED-14910] - Githubissues

elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.

https://elementor.com/

GNU General Public License v3.0

6.45k stars 1.4k forks source link

fix: check for elementor.settings.page in isScrollSnapActive [ED-14910] #27353

Open m1ga opened 2 weeks ago

m1ga commented 2 weeks ago

PR Checklist

[ ] The commit message follows our guidelines: https://github.com/elementor/elementor/blob/master/.github/CONTRIBUTING.md

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Summary

This PR can be summarized in the following changelog entry:

Fixes: https://github.com/elementor/elementor/issues/19345

Uncaught TypeError: elementor.settings.page is undefined when trying to open the Elementor Editor

Description

An explanation of what is done in this PR

*

Test instructions

This PR can be tested by following these steps:

*

Quality assurance

[ ] I have tested this code to the best of my abilities
[ ] I have added unittests to verify the code works as intended
[ ] Docs have been added / updated (for bug fixes / features)

Fixes #

Benlola commented 2 weeks ago

Only Elementor, Elementor Pro and Hello Elementor Theme, no possibility to edit something is give error: "Uncaught TypeError: e.O is not a function"

m1ga commented 2 weeks ago

@Benlola wrong place to post this. This is a PR and not related to the e.O is not a function issue.