elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.
https://elementor.com/
GNU General Public License v3.0
6.6k stars 1.42k forks source link

ActiveCampaign Embed in Popup Displays Form in Footer on Close #8268

Open nodakjones opened 5 years ago

nodakjones commented 5 years ago

Prerequisites

Description

I have the Wordpress ActiveCampaign plugin installed with allows you to use a shortcode to embed an ActiveCampaign form. I have the shortcode widget in a popup so that it is correctly loading the form when the popup is displayed. The problem is that when the pop-up is closed, the form displays in the footer. Each time you open and close the popup a new instance of the form is displayed in the footer.

I've added a note to a different closed issue: https://github.com/elementor/elementor/issues/7898 . I'm creating a new issue because I don't think the closed issue will have much visibility.

Steps to reproduce

  1. Install elementor and elementor pro
  2. Install ActiveCampaign plugin and connect with your api key
  3. Setup form in ActiveCampaign and enable the form in the Wordpress ActiveCampaign settings
  4. Create a pop-up and add the shortcode widget and then place the ActiveCampaign form shortcode, set the rules to show the pop on page load (I've tested various rules and they all have the same issue)
  5. View the page. You should see the form in the pop-up, but when you close the popup you will see the form in the footer.

Isolating the problem

Environment

== Server Environment == Operating System: Linux Software: Apache MySQL version: Percona Server (GPL), Release 84.0, Revision 47234b3 v5.6.40-84.0 PHP Version: 7.1.30 PHP Max Input Vars: 3000 PHP Max Post Size: 128M GD Installed: Yes ZIP Installed: Yes Write Permissions: All right Elementor Library: Connected

== WordPress Environment == Version: 5.2.1 Site URL: https://www.data-imagery.com Home URL: https://www.data-imagery.com WP Multisite: No Max Upload Size: 128 MB Memory limit: 768M Permalink Structure: /%category%/%postname% Language: en-US Timezone: 0 Debug Mode: Inactive

== Theme == Name: DI Version: 1.0 Author: Data-Imagery Child Theme: No

== User == Role: administrator WP Profile lang: en_US User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.169 Safari/537.36

== Active Plugins == ActiveCampaign Version: 7.1.2 Author: ActiveCampaign

ActiveCampaign for WooCommerce
    Version: 1.2.3
    Author: ActiveCampaign

CardConnect Payment Gateway
    Version: 3.1.4
    Author: CardConnect <jle@cardconnect.com>

Elementor
    Version: 2.5.16
    Author: Elementor.com

Elementor Pro
    Version: 2.5.9
    Author: Elementor.com

Essential Addons for Elementor
    Version: 3.0.3
    Author: WPDeveloper

Facebook for WooCommerce
    Version: 1.9.12
    Author: Facebook

Gravity Forms
    Version: 2.4.9
    Author: rocketgenius

Jetpack by WordPress.com
    Version: 7.4
    Author: Automattic

SG Optimizer
    Version: 5.1.3
    Author: SiteGround

Sucuri Security - Auditing, Malware Scanner and Hardening
    Version: 1.8.21
    Author: Sucuri Inc.

WooCommerce
    Version: 3.6.4
    Author: Automattic

WooCommerce Admin
    Version: 0.12.0
    Author: WooCommerce

WooCommerce Services
    Version: 1.20.0
    Author: Automattic

WooCommerce Stripe Gateway
    Version: 4.2.0
    Author: WooCommerce

WooCommerce Subscriptions
    Version: 2.5.5
    Author: Prospress Inc.

== Log == : Log: showing 20 of 322019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_portfolio Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_portfolio Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_products Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_products Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_sitemap Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_sitemap Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_popup_border_radius Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_0_popup_border_radius Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_posts Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_posts Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_portfolio Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_portfolio Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_products Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_products Finished 2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_form Start
2019-05-23 00:13:14 [info] Elementor Pro/Upgrades - _v_2_5_4_form Finished 2019-05-23 00:13:14 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor Pro', 'from' => '2.4.6', 'to' => '2.5.8', )] 2019-05-23 00:13:14 [info] Elementor data updater process has been queued. [array ( 'plugin' => 'Elementor Pro', 'from' => '2.4.6', 'to' => '2.5.8', )] 2019-05-28 15:28:26 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor', 'from' => '2.5.15', 'to' => '2.5.16', )] 2019-05-28 15:29:30 [info] Elementor data updater process has been completed. [array ( 'plugin' => 'Elementor Pro', 'from' => '2.5.8', 'to' => '2.5.9', )]

crsmoore commented 4 years ago

I'm encountering the EXACT SAME issue!

Here's a Loom video demonstrating all the details:

https://www.loom.com/share/aa51f3f6c0b7410ea727c869f89c30c0

DavidWooF commented 4 years ago

Hi! I have the same exact problem as this. I am also using: Elementor Elementor pro ActiveCampagne embed shortcode in elementor popup. Result: when you open the popup the form also displays in the footer of the page. Any solution, advice would be great. Kind regards

WillemMoeskops commented 4 years ago

I had the same problem! I fixed it by just not using activecampaign forms anymore. Instead I used the Elementor form. If you want to do the same, let me explain it:

Hope this helps.

Kind regards.

nodakjones commented 4 years ago

The problem with using the elementor form is that you don't get the site tracking cookie placed from Active Campaign, so you don't have any history of the page views from that user now or in the future. I would suspect that for most people site tracking would be a requirement. There are work arounds with php/js to set the site tracking cookie, but why do this when you just need the active campaign form embed to work via a pop-up.

crsmoore commented 4 years ago

@WillemMoeskops - In addition to what @nodakjones said about the site tracking cookie not working (for new people, which requires an ActiveCampaign form), you also have the additional problem of ActiveCampaign's API not allowing unsubscribed people to resubscribe. If they were previous unsubscribed it does nothing. The only way they can resubscribe again is via an actual ActiveCampaign form.

Please login to your ActiveCampaign account and vote on this issue here --> https://ideas.activecampaign.com/ideas/AC-I-12458

NoemiNL commented 3 years ago

We have encountered the same issue, but open since June 6th 2019 I loose faith in a solution anytime soon. Would be nice if a bug such as this was fixed, lately I encounter more and more issues like these.. Open for months/years. 👎

crsmoore commented 3 years ago

@nodakjones - This is still happening. Can we please kindly get a fix in the next Elementor update?

There's quite a bit of documentation in this thread here and several of us provided a lot of detail.

I also made a short video (under 2 minutes) showing you first-hand the problem (it's linked above, but here it is again):

https://www.loom.com/share/aa51f3f6c0b7410ea727c869f89c30c0

Thanks so much!

withsb commented 3 years ago

Still here in 2021 and the issue is still occurring. We need to be able to use AC forms due to site tracking and resubscribing as stated above and would be best to use in an elementor pop up.

Restating the issue - every time an elementor popup with an AcctiveCampaign form embeded is opened then closed, it puts a copy of the form beneath the footer - and it will put the form there multiple times.

Any solutions found?

withsb commented 3 years ago

Workaround: Use the full embed code in your popup. Note - you will have to paste new code into popup if you update the form in AC.

stijnvanouplines commented 3 years ago

A workaround with CSS:

._form_XX:not(.elementor-popup-modal ._form_XX) { /* change XX with the ID of the form */
    display: none;
}

This hides the form if it's not in an Elementor popup. Now we can use the shortcode [activecampaign form=XX css=0] in a popup.

withsb commented 3 years ago

Perfect thank you. On 9 May 2021, 4:58 AM +1000, Stijn Vanouplines @.***>, wrote:

A workaround with CSS: ._form_XX:not(.elementor-popup-modal ._form_XX) { / change XX with the ID of the form / display: none; } This hides the form if it's not in an Elementor popup. Now we can use the shortcode [activecampaign form=XX css=0] in a popup. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

loomoadmin commented 2 years ago

Thank you for this! @stijnvanouplines

czellweg commented 12 months ago

Brilliant, this also worked for me. Added it to the Custom CSS section of the footer and voilà. 👍

MaxTyer82 commented 8 months ago

BRILLIANT! Thanks so much! Already got some extra grey hair the last hours. And the bug is still not fixed!