elementor / elementor

The most advanced frontend drag & drop page builder. Create high-end, pixel perfect websites at record speeds. Any theme, any page, any design.
https://elementor.com/
GNU General Public License v3.0
6.45k stars 1.4k forks source link

ACF group fields are not showing in the dynamic fields. #9571

Open manoj-identixweb opened 4 years ago

manoj-identixweb commented 4 years ago

Hi there,

I am using the Elementor, Elementor PRO plugin to make using the dynamic fields from ACF. When I added custom fields to the post - Portfolio and tried to get values of them by Elementor PRO's dynamic field, I didn't get the fields fetched to the dropdown.

The following are some screenshots to the WordPress website I am using which can helps you to understand the things I tried to explain. 01) Custom Field - http://prntscr.com/pwsw9p 02) Value in the post - http://prntscr.com/pwsxse 03) Fields showing in the Elementor's dynamic value - http://prntscr.com/pwsxse

I'm working on the local environment for testing some features. Following plugins and themes, I am using on the website.

Theme Active Twenty Twenty

Running with WordPress latest version 5.3

I hope you'll resolve this.

Looking forward to hearing from you.

Thanks in advance,

BradShoemaker commented 4 years ago

Agreed. I would like to see this added as well.

SoundYeti commented 4 years ago

I Agree!

I am having the same issue/ similar. I searched for an hour or so. I tried updating, rolling back etc..

I figured out If you are creating an ACF custom field group with the 'Field Type' set as 'Group' and have any nested options it will not show up in elementor's Dynamic Fields as a key.

But If you take it out of the Group, it works fine as far as I can tell.

This is showing that I have ACF group enabled with sub-options.

Screen Shot 2020-01-28 at 3 57 11 AM

and below you can see since the number 1 spot referenced above is outside of the group the "Does this show up" shows up.

Screen Shot 2020-01-28 at 3 54 32 AM

Testing this again - I deleted the entire Field Group, and started fresh. I added all the desired fields one by one and didn't nest anything in a group. As you can see the Dynamic Keys are magically there now! A fix would be awesome!

Screen Shot 2020-01-28 at 4 13 24 AM
nuresponse commented 4 years ago

I'm having same issue.

Ricarditu commented 4 years ago

Yup, same here! I tried everything, like @SoundYeti, and only a lot later I figured out the issue was the group... Would be nice to see this sorted out. It's normal to group fields, in terms of organization, and these fields should also show just as the non-grouped ones. Thanks!

hking1991 commented 3 years ago

Same issue. Please fix this bug.

blakemiller99 commented 3 years ago

+1 here. I had to pull all of my sub fields out into regular fields after realizing IE wouldn't see them. I'm assuming it's not easy, but hopefully it can be solved.

shaneonabike commented 3 years ago

I also noticed this issue and groups are a great way to organize fields when you have a lo to enter. It must be just a matter of determining if there are groups on an ACF field and then grabbing any data within those groups appropriately.

Basically, a santity test like $groups = acf_get_field_groups(array('post_type' => 'your-post-type')); and then

loop through any found groups $fields = apply_filters('acf/field_group/get_fields', array(), $field_group_id); end loop

arekuki commented 3 years ago

+1

DigitalBerry commented 3 years ago

+10 for this!

chitiore commented 3 years ago

+1

brahimvandenbrande commented 3 years ago

+1

travisC commented 3 years ago

+1

iamhazel commented 3 years ago

Also having this issue. I have upwards of 20 fields so field groups were a great option until I realized they are unusable ☹

NielsFS commented 3 years ago

Ran into the same problem, please fix 👍

pinkbirch commented 3 years ago

Need this too!

bryan042092 commented 3 years ago

+1

Noob86 commented 3 years ago

Okay, I just thought this would be a temporary bug with WP 5.6 or something, but this goes back to nov. 2019? 😱 Why hasn’t this been solved, because I agree that using groups in ACF is pretty much a necessity to keep things organized.

jferragut commented 3 years ago

Bump. This is occurring in the Latest versions.

Elementor PRO version 3.0.9 ACF PRO version 5.9.4

After testing further, It happens with Groups or Tabs. Individual fields are not an issue, but anything that is withing a group or tab is invisible in Elementor PRO dynamic fields.

Any ETA on this? I see this has been occurring since 2019 and here we are in 2021. @KingYes @Nevoss @udidol @matipojo

busymick commented 3 years ago

+1

ghost commented 3 years ago

+1

task1tvs commented 3 years ago

I’ve just spent the past 2 days creating the most beautifully organised custom fields for rental properties to discover this issue. I don’t understand what the point of having ACF Pro is if we can’t access groups/tabs.

Would really appreciate if anyone has found a work around using other plugins rather than E Pro for the solution.

sndb010 commented 3 years ago

So I have found out that Anywhere Elementor (https://wordpress.org/plugins/anywhere-elementor/) is able to display Group and Tab Fields, however this is of course a workaround. This issue should definitely be fixed by now!

KingMatrix1989 commented 3 years ago

Same issue. please fix this bug.

nadworks commented 3 years ago

+1

AE's not an option really since the ACF is needed as a native dynamic option. Also, the need for plugin after plugin just to solve relatively straight forward scenarios is getting ludicrous.

Proktologe commented 3 years ago

+1

elementor is expensive enough to implement more basic features - like ACF groups/repeater in tables or something ... the same applies to Submit-Forms there is a need to display ACF groups/repeater fields

0xFlo commented 3 years ago

Pretty obvious to me that the issue has not been fixed BECAUSE we're supposed to buy ACF PRO. I bet $49 that the "REPEATER" field (who even came up with this label?) is working just fine with Elementor Pro. The only mistake ACF has done after offering a "PRO" version is to have left the "GROUP" field for the freemium version. It is indeed unbelievable that we can not group fields in the free version and that this has been an issue for years!

task1tvs commented 3 years ago

I can confirm that it doesn’t work with Elementor Pro

On Sat, 27 Mar 2021 at 19:07, Florianrulz @.***> wrote:

Pretty obvious to me that the issue has not been fixed BECAUSE we're supposed to buy ACF PRO. I bet $49 that the "REPEATER" field (who even came up with this label?) is working just fine with Elementor Pro. The only mistake ACF has done after offering a "PRO" version is to have left the "GROUP" field for the freemium version. It is indeed unbelievable that we can not group fields in the free version and that this has been an issue for years!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elementor/elementor/issues/9571#issuecomment-808788027, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVH34OPENF6DM7JPUPIOUDTFYUH7ANCNFSM4JNI63YA .

-- Gemma da Silva | TASK IT! Virtual Solutions m: +351 914 731 028 e: @.*** w: www.taskit.eu

0xFlo commented 3 years ago

What the "Repeater" field doesn't work or the "Group" field doesn't work?

task1tvs commented 3 years ago

I could only get it working with standard fields on top level ie not fields with sub fields. So it doesn’t work with group, repeater, accordion, tabs etc.

I had set up my back end to look so good in tabs with group fields and had to drag them all out

On Sat, 27 Mar 2021 at 19:12, Florianrulz @.***> wrote:

What the "Repeater" field doesn't work or the "Group" field doesn't work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elementor/elementor/issues/9571#issuecomment-808788527, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASVH34O4ANYVEFTLOCJ3FIDTFYUYFANCNFSM4JNI63YA .

-- Gemma da Silva | TASK IT! Virtual Solutions m: +351 914 731 028 e: @.*** w: www.taskit.eu

0xFlo commented 3 years ago

That's terrible. I've only spent a couple hours grouping the fields. I guess we'll have to find an alternative...

digitayfun commented 3 years ago

Does somebody read this from Elementor?

0xFlo commented 3 years ago

nope

On Fri, Apr 9, 2021 at 8:21 PM digitayfun @.***> wrote:

Does somebody read this from Elementor?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/elementor/elementor/issues/9571#issuecomment-816677569, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANWQBGWJWHAY45YD2VK3FJDTH35OPANCNFSM4JNI63YA .

gigiwest123 commented 3 years ago

How is this still an issue?

svrdoljak123 commented 3 years ago

Any solutions????

ajoah commented 3 years ago

@svrdoljak123 for the moment the only solution is to create your own dynamic tag...

If it can help anyone, here is mine : https://gist.github.com/ajoah/35e3ca535e71677fccfdbfb7d0addb4d#file-acf_image_group_dynamictag-php It works only for image field specifically for my use but if you modify this line : https://gist.github.com/ajoah/35e3ca535e71677fccfdbfb7d0addb4d#file-acf_image_group_dynamictag-php-L191 maybe it could work on an other field type.

To make my tag, i looked elementor classes in : elementor-pro/modules/dynamic-tags/acf. As you can see there is a tag by field type.

jaugustodias commented 3 years ago

+1

Solved with @SoundYeti solution. Rebuild without nesting.

Ezra-Siton-UIX commented 3 years ago

MEGA MEGA BUG

MEGA BUG ==> very bad user experience (How someone should guess why this not working).

sermalefico commented 3 years ago

up!!!

DragonsBloodKush commented 2 years ago

If you are using button groups like I was, this might help: https://elementor.com/help/elementor-acf/ Very Painful and Expensive. Trust-loss. Hat Tip: Patrick at ACF

-- Custom ACF fields we support: Note: Any ACF fields not included in this list, such as repeater fields, are not supported at this time.

Text: ‘text’, ‘textarea’, ‘number’, ‘email’, ‘password’, ‘wysiwyg’, ‘select’, ‘checkbox’, ‘radio’, ‘true_false’,

Pro ‘oembed’, ‘google_map’, ‘date_picker’, ‘time_picker’, ‘color_picker’ ‘date’ ‘date_time_picker’

URL: ‘email’, ‘image’, ‘text, ‘file’, ‘page_link’, ‘post_object’, ‘relationship’, ‘taxonomy’, ‘Url’

Image: ‘image’ ‘gallery’

jdev-d commented 2 years ago

Still not working with their latest update 5.9.8

joshuamayo commented 2 years ago

I'm going to be honest with you guys... as much as I love Elementor, I also hate it a ton. There are so many small things like THIS that seem so obvious that are missing from the plugin. And the fact that this issue was brought up nearly 3 YEARS ago and there is no solution is unexplainably stupid. And they don't care. But you know what... there will be another plugin that comes along and eventually dethrones Elementor, and that plugin will inevitably win the battle of page builders because they will listen to their customers more.

donstefanos commented 2 years ago

I had the same problem and found no free solution, I use a special dynamic plugin and this also solves the problem: https://www.dynamic.ooo/widget/acf-fields/ It can handle Groups and more. 2021-08-02_09-42-31

MenschLennart commented 2 years ago

still not working. :/ That's a shame.

sermalefico commented 2 years ago

Please permit search acf meta inside groups

giordanacamargo commented 2 years ago

no solution yet...

Mx5jdm commented 2 years ago

Still nothing, C'MON ELEMENTOR !!

0xFlo commented 2 years ago

Elementor is dead they're just milking their brand and it is going to die slowly like all the other page builders. I recommend moving away from pagebuilders like this and to use ACF + custom theme

umer310 commented 2 years ago

add_shortcode('repeater', 'wporg_shortcode'); function wporg_shortcode( $atts = [], $content = null) { // do something to $content // always return

if(!function_exists('the_repeater_field')){
    return null;
}

$repeater  = get_post_meta( get_the_ID() , 'what_we_do', true);

ob_start();
if(!empty($repeater) ) {

    echo '<ul class="as-what-we-do-ul">';
    while( the_repeater_field('what_we_do', get_the_ID()) ) {
        echo '<li>';
        echo '<h3 class="as-what-we-do-head"> ' . get_sub_field('service_name') . '</h3><div class="service-details">';

        $service_description = get_sub_field('service_descrpatoion');
        if($service_description){
            printf('<div class="service-description">%s</div>', $service_description);
        }

        $service_link = get_sub_field('service_link');
        if($service_link){
            printf('<div class="service-link"><a href="%s" target="_blank" class="elementor-button-link elementor-button elementor-size-sm" role="button">
                <span class="elementor-button-content-wrapper">
                    <span class="elementor-button-icon elementor-align-icon-right"><i aria-hidden="true" class="fas fa-external-link-alt"></i></span>
                    <span class="elementor-button-text">View</span>
                </span>
            </a></div>',
            $service_link
            );
        }
        echo '</div></li>';

    }
    echo '</li></ul>';
}

return ob_get_clean();

}

artiemart commented 2 years ago

+1

valesilvestri commented 2 years ago

I use shortcode instead acf field in dynamic tag: [acf field="group_field"] or [acf field="repeate_row_field"]. It is only a workaround and sometimes it is not enough. I hope the solution is arriving.