search

elementor / hello-theme

A plain-vanilla theme, best suited for building your site using Elementor plugin. This theme resets the environment and prepares it for smooth operation of Elementor.
https://elementor.com/hello-theme/
572 stars 225 forks source link

Fix: Wrap page `<h1>` with `<div>`, not `<header>` [ED-13998] #374

Closed rami-elementor closed 7 months ago

rami-elementor commented 7 months ago

BREAKING CHANGES!

The theme uses <header> tags twice, on site headers and inside the content area on page headers. To improve semantics, the theme should change tags and the <h1> tags don’t really need a wrapping header.

The current HTML structure:

<header id="site-header" class="site-header">
</header>

<main id="content" class="site-main">
    <header class="page-header">   <!-- Should be a regular div -->
        <h1></h1>
    </header>                      <!-- Should be a regular div -->

    <div class="page-content">
    </div>
</main>

<footer id="site-footer" class="site-footer">
</footer>

The suggested HTML structure:

<header id="site-header" class="site-header">
</header>

<main id="content" class="site-main">
    <div class="page-header">
        <h1></h1>
    </div>

    <div class="page-content">
    </div>
</main>

<footer id="site-footer" class="site-footer">
</footer>