search

elementor / lokl-cli

Interactive script to launch and manage your Lokl sites
The Unlicense
66 stars 7 forks source link

bugfix hello-world cluttering #9

Open KasperZutterman opened 3 years ago

KasperZutterman commented 3 years ago

This is a bugfix for Lokl - Docker hello-world cleanup - #16 Using docker info to check if Docker is running.

leonstafford commented 3 years ago

Cheers, thanks for finding right repo!

My original intention with the hello-world was to lazily check that docker without sudo had enough permissions to launch an image.

I don't have a sudo requiring setup to check if this docker info will work as intended. Are you able to check?

Else, there's this automatically rm container after run:

docker run --rm hello-world...

If we can get away from that slow pulling and running of hello-world, would be nice improvement...

KasperZutterman commented 3 years ago

Ah I see, I am unable to check if it runs without sudo on my Windows machine, unfortunately.

leonstafford commented 3 years ago

@KasperZutterman no worries. We can do the rm thing for now and look into better (faster) options to test their Docker setup.

I had some exciting progress last night moving to new way of building. There's much less happening when you create a new container from the Lokl interactive script now - just this vs before, it would be doing some MySQL setup and WordPress installation. It does mean the initial Docker image that gets pulled down is a bit bigger (1.3GB vs 0.9GB), but can probably trim that down.

leonstafford commented 3 years ago

(still not merged/published to main script on website yet. I've been developing the php8 image, but rearranging things so that we can choose either php7 or 8 in the interactive script)