search

elementor / static-html-output

Static HTML Output Plugin for WordPress
https://statichtmloutput.com
The Unlicense
124 stars 33 forks source link

add CLI progress indicators for deploy command #101

Open leonstafford opened 4 years ago

leonstafford commented 4 years ago

added in tag 6.6.18 to UI, need to git into CLI deploy command, too

leonstafford commented 4 years ago

@crstauf do you want to have a go at this for one of the deploy methods? (besides zip or netlify, as those don't really progress, just 1 zip file is built)

you'll see in the UI that it's just using a "files remaining to download". My brain's a bit fried from looking at the deployer codes, but you may have clearer mind. There's some more complexity in GitLab and I think Bitbucket, due to them doing a multi-stage process to batch deploys.

I'm happy with that for this release, but in future, we can add a new DB table DeployLog similar to CrawlLog, in order to track original total of deployable files to use a % indicator, along with tracking which ones are DeployCache hits, which is similar to what https://github.com/WP2Static/wp2static is going.

No pressure/obligation, I can pick this up later

crstauf commented 4 years ago

@leonstafford Sure, I can take a look tonight and see if I can wrap my brain around them enough to implement progress bar.

crstauf commented 4 years ago

@leonstafford I got started with the PR (with BitBucket), but (and I can't believe I didn't realize this earlier) I won't be able to actually perform the deployments to test, because I don't have accounts with all the deployment methods, so I'll need your assistance to actually run the command.

leonstafford commented 4 years ago

@crstauf haha, no worries - it can be a pain to set them all up, I'm afraid to blow away my main local dev instance for that reason!

Just gave BitBucket a shot - it jumped from 20% (bootstrapping) to 100% and then hung there until complete. BitBucket and I think GitLab will always be a bit jumpy, as can mark the files complete only when the batch is successful, so good to test with small batch sizes to confirm behaviour is as expected.

crstauf commented 4 years ago

@leonstafford I've not yet implemented progress for the batches, so hopefully that'll be completed soon. I definitely expected it to stall for awhile, but shouldn't have been on 100%. I'll work on that.

crstauf commented 2 years ago

@leonstafford FYI I'm not going to get back to this unfortunately.