search

elementor / wp2static

WordPress static site generator for security, performance and cost benefits
https://wp2static.com
The Unlicense
1.43k stars 270 forks source link

roots.io sage dist folder not detected for export #267

Closed leonstafford closed 5 years ago

leonstafford commented 5 years ago

to investigate

webpack generated dist dir may contain scripts, styles, fonts, images. In user-reported case, only images was missing, but adding via Additional URLs solved it.

Look to detect Sage theme or dist dir and add to additional URLs

This may be a good time for me to try a companion plugin, like WP2Static Sage or such, to hook into the URLs queue and add Sage-related things...

leonstafford commented 5 years ago

@giacomoalonzi - this should be "fixed" now dist was previously added as an exclude,along with other common build files, not realizing this was required for Sage. It may include too much for other libs that have their dist dir included, but can be filtered out in those cases. More is better when it comes to asset detection!

Please give the attached a test. This is now in the develop branch

sage_dist_inc.zip

giacomoalonzi commented 5 years ago

@leonstafford nope, there's an error in the crawling process, but it's not printed out in the debug log