elements-at / ProcessManager

Manage processes in Pimcore
Other
45 stars 31 forks source link

Remove forced dark background on download icon #177

Closed NiklasBr closed 8 months ago

NiklasBr commented 1 year ago

Before:

Screenshot 2023-05-02 at 16 21 16

After:

Screenshot 2023-05-02 at 16 21 44

Before accepting/merging: Is it used anywhere else? It seemed so, but I could not find it.

ctippler commented 1 year ago

Hi, i don't think that it is used somewhere else. The main reason for the dark background color is, that on some monitors (especially older ones) it is very hard to see the download icon when there is no background set. Because of the low contrast from green to grey.

So i would keep the dark background or we switch to another Icon which is more visible on the green background.

Regards, Christian

NiklasBr commented 1 year ago

I understand. But maybe the green is the main issue? Consider that the white text on the completed progress bar is lacking contrast as well. What if we also choose a darker green?

APochmann commented 1 year ago

Just some thoughts from my side: I like the idea to get rid of that black box and darker green seem to be good idea too, but a few topics have to be considered:

image

NiklasBr commented 11 months ago

I understand, so maybe it is better to just keep it like it is and await that refreshed admin UI which I think has been in the works for a while, feel free to close this one.