Remove json encode for child process metadata

elements-at / ProcessManager

Manage processes in Pimcore

Other

45 stars 31 forks source link

Remove json encode for child process metadata #197

Closed muratbinerbay closed 8 months ago

muratbinerbay commented 8 months ago

Removes use of json_encode when executing child processes to match setMetadata function parameter type
Fixes bug where an exception was thrown when loading a predefined config, which meant the predefined config could not be loaded at all
Adds background colours back to process list

muratbinerbay commented 8 months ago

@ctippler I hope the change for background colours is OK? :) Was not sure why it was removed but we thought it made it easier to view the process list

muratbinerbay commented 8 months ago

Hi @ctippler, did you get a chance to look at this PR? If not yet, we would fork it to our repository for a while :)

Thanks!

ctippler commented 8 months ago

Hi, thx for the PR. I just removed the backgroudn color because this causes issues with the icons so i think its easyer to with just the white background. Changes are in v5.0.7 .

Regards, Christian