elenakrittik / gdtk

A versatile Godot toolkit with aim on speed, extensibility and friendliness.
5 stars 2 forks source link

Clean-up `Prompt` implementation. #139

Closed elenakrittik closed 1 week ago

elenakrittik commented 1 week ago

While i'm sure it's behavior is solid, the code itself is quite wacky and the boundaries between different types are weak and unclear. Many fields are pub even though it seems like they shouldn't be, and it's also inconvenient from the user side that items need to be a Vec (an iterator would be ideal, but a slice is more realistic).