elenirotsides / Trivia-Bot

Be Educated. Be Fun. Be Trivia on Discord. 🧠

https://discord.com/api/oauth2/authorize?client_id=831974682709721099&permissions=157760&scope=bot

MIT License

13 stars 10 forks source link

Getting it working #144

Open elijahd123 opened 1 year ago

elijahd123 commented 1 year ago

Description

We have completely re-written the bot so that it works with slash commands and uses buttons instead of reactions.

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

Checklist:

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation (if applicable)

elenirotsides commented 1 year ago

Hi @elijahd123 @alanschapira thank you for your PR! Would you like me to review this or is it not ready yet? If it isn't ready, please mark this review as a draft PR. Additionally, please fill out the PR template when you're ready.

elijahd123 commented 1 year ago

@elenirotsides Hey! This is ready for review now, and perhaps some QA testing too.

elijahd123 commented 1 year ago

Things to test

[ ] Multiple simultaneous games in the same server
[ ] Multiple simultaneous games in different servers
[ ] Play a game with 10+ people

What happens if someone runs the slash command twice in the same channel?

Are there any UI changes that you would like us to make?

elenirotsides commented 1 year ago

Oh my goodness this is incredible! 🤩 My personal computer has been unusable for a few months and have been unable to continue my work on this, so this PR is so so so appreciated! I actually have a new computer coming tomorrow, so I'll be able to take a look at all of this sometime this week. Again, thank you so so much for the time you both put into this; I will let you both know my thoughts soon! 🙌 @elijahd123 @alanschapira

alanschapira commented 1 year ago

Im struggling to get the fork to merge with your main. Will try again later when I have time

elenirotsides commented 1 year ago

If you need help with the merge, let me know and I'd be happy to assist @alanschapira

elenirotsides commented 1 year ago

Hi guys @alanschapira @elijahd123 are you still working on this? Is there anything you need from me? I can take the work you've both done and continue on with it but if this is still actively being worked on, please let me know so I don't disrupt your flow. I'm very grateful to you both for this fantastic PR and am looking forward to getting the bot fully working again!

alanschapira commented 1 year ago

Sorry I've been a bit too busy to finish this up. Feel free to take over at this point. You can use whatever you want and change whatever you want! In theory its working as is, but let me know if you cant get it working

elenirotsides commented 1 year ago

Sorry I've been a bit too busy to finish this up. Feel free to take over at this point. You can use whatever you want and change whatever you want! In theory its working as is, but let me know if you cant get it working

No problem, thanks for letting me know! And thanks for the PR; I'm excited to see slash commands working! I'll be messing around with this to give it the styling and functionality changes that I'm seeking but otherwise, the credit is all yours @alanschapira and @elijahd123 ! Excellent work, I really appreciate the help!