Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every execute call to avoid data race

elennick / retry4j

Lightweight Java library for retrying unreliable logic - DEPRECATED

MIT License

202 stars 26 forks source link

Mark CallExecutor as ThreadUnsafe or force user to create CallExecutor in every execute call to avoid data race #88

Open jeremyfu-aws opened 1 year ago

jeremyfu-aws commented 1 year ago

Since CallExecutor has status as instance variable to store result, it is needed to create new CallExecutor in every execute call, otherwise it could cause data race under multi-threaded environment.

In order to avoid the misuse of CallExecutor, please consider to

add ThreadUnsafe annotation on CallExecutor
or implement in a way which forces users to create new CallExecutor in every execute call

elennick commented 1 year ago

@jeremyfu-aws i am no longer going to be maintaining retry4j - however please feel free to fork and make whatever changes you'd like