search

elephaint / pgbm

Probabilistic Gradient Boosting Machines
Apache License 2.0
138 stars 20 forks source link

MANIFEST.in paths not separated by / #14

Closed jlfsjunior closed 2 years ago

jlfsjunior commented 2 years ago

Describe the bug First of all, thanks for this nice package and for providing many examples.

The paths in MANIFEST.in are written in Win format (with \ separator), therefore ignored when installing from source in Unix.

From the MANIFEST.in docs:

File & directory names in MANIFEST.in should be /-separated; setuptools will automatically convert the slashes to the local platform’s appropriate directory separator.

To Reproduce Steps to reproduce the behavior:

  1. On linux, install from source via python setup.py install

  2. Warning are logged during installation:

reading manifest template 'MANIFEST.in'
warning: no files found matching 'src\pgbm\splitgain_cpu.cpp'
warning: no files found matching 'src\pgbm\splitgain_cuda.cpp'
warning: no files found matching 'src\pgbm\splitgain_kernel.cu'
warning: no files found matching 'src\pgbm_dist\parallelsum.cpp'
warning: no files found matching 'src\pgbm_dist\parallelsum_kernel.cu'
  1. Run the first example will return an error: 
    FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.10/site-packages/pgbm/splitgain_cpu.cpp'
elephaint commented 2 years ago

Hi,

Thanks for reporting. Didn't know that. I'll fix it right away!

elephaint commented 2 years ago

Hi,

Fixed it, should work now. Weird that it did not work for you, since we have Github actions checking compliance on Linux installations which gave no complaints (?)