elephant-track / elephant-server

A server implementation of ELEPHANT
BSD 2-Clause "Simplified" License
7 stars 5 forks source link

Issues for distributing ELEPHANT's singularity image #22

Closed RubenRam closed 1 year ago

RubenRam commented 1 year ago

In order to distribute the Singularity image among different users, there should be an option to explicitly run the %runscript section of the elephant.def description file that copies the content of /var to the users .elephant_binds folder.

Right now this is only done in the make singularity-build option:

singularity-build:
        singularity build --fakeroot elephant.sif elephant.def
        singularity run --fakeroot elephant.sif

However, if the image is already available, the user (one that hasn't run the build) executes the "make singularity-launch" instruction which lacks the runscript setup. If the runscript section is not executed, the user will be missing the .elephant_binds content and thus the server services (e.g.: RabbitMQ) fail to start.

I'd suggest adding another option in the Makefile such as "make singularity-setup" that explicitly runs the runscript section

        singularity run --fakeroot elephant.sif
ksugar commented 1 year ago

Thank you for your feedback! (and sorry for the late reply...) It's a good suggestion, and I will introduce it in the next release.