search

elephantrobotics / mycobot_ros

A ros package for myCobot.
BSD 3-Clause "New" or "Revised" License
154 stars 81 forks source link

Update docker to noetic #49

Closed mostlyjason closed 1 year ago

mostlyjason commented 2 years ago

Noetic was released on May 23rd, 2020 and is the new stable version for ROS. It's also listed as supported in the README for this repo. Would it make sense to update the default for docker to Noetic? I tested mycobot_320_slider.launch and mycobot320_moveit.launch and they both seem to work.

I also removed the variable ROS_DISTRO from the Dockerfile since hardcoding it in one place by not another may lead to inconsistent behavior.

mostlyjason commented 2 years ago

On further testing, I discovered that the Moveit Plugin in Rviz seems to be rendering incorrectly. The context and planning tabs seem to work fine. However, changing to other tabs like joints shows one of the boxes not being painted correctly. I'm unsure if this is something particular to the moveit_rviz_plugin or something particular to my machine. I'm running it on Ubuntu 20.04 with the Nvidia driver in Docker. If others experience this, let me know.

Here is a recording showing the incorrect behavior: https://user-images.githubusercontent.com/6370704/147966942-3219a10b-0e64-488a-afe4-8809d5bef46e.mp4

I wouldn't recommend merging this change until we troubleshoot this problem. I'll leave it up to the maintainers of this repo whether to close this PR or use it for discussion.

fedorenchik commented 1 year ago

This was closed by GitHub automatically, but should probably be merged.

fedorenchik commented 1 year ago

I've added support for both noetic and melodic in docker in noetic branch based on this PR. However I wasn't able to merge this PR directly as most of the code is changed. Thank you for your idea.