elephantrobotics / pymycobot

This is a python API for ElephantRobotics product.
MIT License
109 stars 54 forks source link

Unnecessary fix for is_servo_enable() in v2.5.8 #21

Closed 3110 closed 3 years ago

3110 commented 3 years ago

Describe the bug The fix 4b4a14419463067e6f788c77598688118bce9b66 is unneccesary. You have to fix the reply of is_servo_enable() from AtomMain v3.2 instead.

To Reproduce AtomMain v3.2 replies the unnecessary joint number(6) for is_servo_enable(6).

Sending:  fe fe 03 50 06 fa
Received: fe fe 04 50 06 01 fa

Expected behavior

Sending:  fe fe 03 50 06 fa
Received: fe fe 03 50 01 fa

Other commands that specify a joint number do not include it in their reply.

Desktop:

zlj-zz commented 3 years ago

I'm not sure why, but that's what we designed.

zlj-zz commented 3 years ago

I asked my colleagues. This is used to confirm information and prevent loss during asynchronous communication.

3110 commented 3 years ago

Thanks, I understand what you intend to.