elerch / SAML2

Fork of SAML2 library on codeplex. This library removes dependencies on Asp.net
Mozilla Public License 2.0
117 stars 62 forks source link

Fix for the RedirectUrl to handle urls with query params #13

Closed zarusz closed 8 years ago

zarusz commented 8 years ago

For the SignOn flow, when the return url contained an equals (=) sign (e.g. url with query params) it was cut off after the first equals sign.

For example this was my return url: /Auth/SignIn?param1=http%3A%2F%2Flocalhost%3A9000%2F%23%2Fhome

When the SignOn response came in, this library was redirecting to: /Auth/SignIn?param1=

Internally the RelayState was using equals (=) to express key-value pairs, but the value was not escaping any potential equal signs.

Have a look at my unit test.

zarusz commented 8 years ago

@elerch will you consider integrating this pull request?

elerch commented 8 years ago

Merged - thanks for adding the tests!