search

elerch / SAML2

Fork of SAML2 library on codeplex. This library removes dependencies on Asp.net
Mozilla Public License 2.0
117 stars 63 forks source link

Sign-On / Sign-Off Binding Locations with ? Fail When Sending Request #7

Closed jbparker closed 8 years ago

jbparker commented 8 years ago

In src/Owin.Security.Saml/SamlMessage.cs, the following code produces a bad uri if request.Destination contains a ?:

var redirectLocation = request.Destination + "?" + redirectBuilder.ToQuery();

In trying to use Google Apps new IdP (which passes the IdP as a query parameter), the request fails since the SAMLRequest parameter is not appended with & but instead with an additional ?.

jbparker commented 8 years ago

Hey @elerch - can we get a new version of the NuGet package pushed with the changes? Thanks!