search

elesto-dao / elesto

The ElestoDAO node
Apache License 2.0
4 stars 1 forks source link

feat(iavl): upgrade to osmo iavl #217

Closed PaddyMc closed 1 year ago

PaddyMc commented 1 year ago

Description

How to test

Benchmark

gsora commented 1 year ago

I'm not sure how I feel having to depend on Osmosis's SDK fork... They might stay behind mainline SDK or worse, could change the behavior of some bits and pieces we give for granted.

Also, what if we want to use newer IBC features that require new SDK functionalities, and they don't want to deal with that?

PaddyMc commented 1 year ago

I'm not sure how I feel having to depend on Osmosis's SDK fork... They might stay behind mainline SDK or worse, could change the behavior of some bits and pieces we give for granted.

Also, what if we want to use newer IBC features that require new SDK functionalities, and they don't want to deal with that?

Yeah, I agree, I don't think switching at this late stage would be good, would introduce a whole host of issues in the future!

This PR was just exploritory.

noandrea commented 1 year ago

Local tests show a ~10% improvement in perf (source @PaddyMc ) but introducing an Osmosis dependency at the moment is considered risky