eleurent / twitter-graph

Fetch and visualize the graph of your Twitter friends and followers.
392 stars 46 forks source link

previous and next cursors variables are reversed resulting in a 5000 friends dump limit #43

Closed stygmate closed 1 year ago

stygmate commented 1 year ago

https://github.com/eleurent/twitter-graph/blob/dc5b742f6ac72609ec88647f6cf45e0455b15b2d/app/fetch_data.py#L172

eleurent commented 1 year ago

Mmmh, looks like this happened with the switch from python-twitter to tweepy (PR). Are you positive the right order should be (previous, next)? I can't find anything in the documentation, it looks like we're supposed to use the Cursor class... and get_friends_id is supposed to just return a List[int]

stygmate commented 1 year ago

if i remember get_friends_id return (previous_cursor, next_cursor), list if cursor parameter is filled. I have tested and it seems to work well.

eleurent commented 1 year ago

Yes I think you're right. This is now fixed, thanks a lot!