elevenhsoft / WebApps

Web applications at your fingertips.
GNU General Public License v3.0
73 stars 5 forks source link

[Bug] Choose PNG icon doesn't work #43

Open ZorinFoss opened 3 weeks ago

ZorinFoss commented 3 weeks ago

Hi,

After update to v0.4.6 which it support png, I try to choose png icon to app and it didn't work. The app create svg file with the app name APPNAME.svg instead.

Thanks,

elevenhsoft commented 3 weeks ago

It converts png to svg for consistency. This way icons copied to your directory are all in one format.

ZorinFoss commented 3 weeks ago

converted file is corrupted and empty.

Tahinli commented 1 week ago

I think I'm also seeing this, I added logo to my icons as png and it's in icons but when I selected logo just seems like broken.

elevenhsoft commented 1 week ago

For me it works. Are you sure you trying to convert from png and not JPEG? It's the only issue comes to my mind for now. The whole conversion process is only embedding png image as base64 encoded data into svg. But PNG is hard coded and it you trying to use JPEG for this, it can fail.

Tahinli commented 1 week ago

For me it works. Are you sure you trying to convert from png and not JPEG? It's the only issue comes to my mind for now. The whole conversion process is only embedding png image as base64 encoded data into svg. But PNG is hard coded and it you trying to use JPEG for this, it can fail.

mine was png