Here's some more patches on the part-of-speech section. I namely found some <gram type="pos">properNoun</gram> unsupported and thought maybe it should be. The dictionary I'm looking at uses these values from an unknown vocabulary, but I figured, since this XSLT is the advertised canonical method of conversion, and since we already support a number of dictionary-specific (French) terms, and particularly since e.g. properNoun is already valid in Lexinfo, they maybe should be supported too.
We could then state the transformation supports POS tags in UD2, Lexinfo3, simple english ...
Sincerely hope you don't dislike my contains() hack. :sweat_smile:
Additionally, fixed two not-sure-but-likely bugs in the nearby lines.
Here's some more patches on the part-of-speech section. I namely found some
<gram type="pos">properNoun</gram>unsupported and thought maybe it should be. The dictionary I'm looking at uses these values from an unknown vocabulary, but I figured, since this XSLT is the advertised canonical method of conversion, and since we already support a number of dictionary-specific (French) terms, and particularly since e.g.properNounis already valid in Lexinfo, they maybe should be supported too.We could then state the transformation supports POS tags in UD2, Lexinfo3, simple english ...
Sincerely hope you don't dislike my
contains()hack. :sweat_smile:Additionally, fixed two not-sure-but-likely bugs in the nearby lines.