search

eleybourn / Book-Catalogue

A book cataloging tool for Android phones.
https://github.com/eleybourn/Book-Catalogue/wiki
GNU General Public License v3.0
384 stars 186 forks source link

Contacts permission? #179

Closed Grunthos closed 13 years ago

Grunthos commented 13 years ago

Just wondering why we need it?

The loan system does not seem to use ut (though it probably will later), but do we need it now?

Also, when we do want to use it, can we give the user the option of diabling it?

eleybourn commented 13 years ago

It uses it to populate the helper dropdown. However given some of the comments, maybe we should remove it.

And no, we can't give the use the option to disable. Permissions are either on or off at install time.

Grunthos commented 13 years ago

Ah, ok. For me the dropdown never drops down.

In terms of permissions...when I get a notification that "app xyz want to access my location..." or similar that is not dynamically granting a priv?

eleybourn commented 13 years ago

Not really similar. That is the app playing nice, you still need to grant the app permission to access location, GPS etc at install time.

This is the problem that most people have.

Grunthos commented 13 years ago

Ah, got you. And from what I read that is pretty much set in stone with Android.

So, if we want a minimum-permissions version we just need to remove contacts lookup. This seems to leave 2 option for supporting a more fully-featured loans system:

  1. Create two versions of the app; one with and one without contacts access.
  2. Create a BookCatalgueLoans applet that has one Activity (display a 'Loan To') dialog and, if present, have the main app use it. If not present, the main app just uses a much simplified screen.

Can you think of anything else?

eleybourn commented 13 years ago

Honestly, given how minor that functionality is I would just remove it.

eleybourn commented 13 years ago

Removed