[suggestion] add HTTP 200 response on Stremio stream endpoint instead of 429

funkypenguin commented 1 month ago

🤪 Sanity check

[X] I have searched and confirmed no existing open / closed issues, or open / closed PRs exist for this app

🤕 What's not right?

Currently Traefik's rate-limit middleware returns a 429 when a user exceeds a ratelimit, even a streamio stream. If a stremio user is rate-limited, they just don't see their stream start at all.

🤯 Here's my idea!

If we instead return a redirect to a video explaining that the rate-limit has been hit, this will be a better experience for users, who would otherwise assume that the addon is broken

https://cdn.discordapp.com/attachments/1260445123494285372/1290957926931894343/image0.jpg?ex=66fe59c2&is=66fd0842&hm=529a02ccda1166d8df7945c7af34e0c0f7f2eade42df9f80c8302122c57b7b2d&

🤔 On the other hand..

Will need to find a way to make this work with traefik

🤩 But will it fly?

It works for the comet proxystreaming addon, it should work for stream endpoints

💬 Your Discord username

No response

mhdzumair commented 1 month ago

Here is the expected response you will need to send to stream's endpoint.

{
  "streams": [
    {
      "name": "ElfHosted (title)",
      "description": "RateLimit Occured (description)",
      "url": "you can provide a video url that explain the user access got blocked due to rate limit."
    }
  ]
}

Update the values correctly. You may use url or externalUrl to point out a website.

funkypenguin commented 2 weeks ago

We have this working for mediafusion now, need to retrofit it to the other addons

mhdzumair commented 2 weeks ago

Yup, this is nice feedback to get track of ratelimit.

elfhosted / enhancements