elfi-dev / elfi

ELFI - Engine for Likelihood-Free Inference
http://elfi.readthedocs.io
BSD 3-Clause "New" or "Revised" License
265 stars 60 forks source link

BSL update pre sample methods #451

Closed uremes closed 1 year ago

uremes commented 1 year ago

Summary:

added seeds to all methods that generate data and added option to calculate standard deviations for several simulation counts in one call so that log_SL_dev matches select_penalty where this option was available. now both methods simulate max(n_sim) samples in each iteration and use the first n to calculate the likelihood score for each n in n_sim.

also updated select_penalty to use warnings rather than sklearn.utils._testing since warnings has been used elsewhere in the codebase.

Please make sure

If your contribution adds, removes or somehow changes the functional behavior of the package, please check that

and the proposed changes pass all unit tests (check step 6 of CONTRIBUTING.rst for details)

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: