search

elgalu / docker-selenium

[NOT MAINTAINED] Please use <https://github.com/SeleniumHQ/docker-selenium>
https://github.com/SeleniumHQ/docker-selenium
Other
1.42k stars 333 forks source link

Could you put some extra RUN command related to PepperFlashPlugin to the elgalu/selenium image? #290

Closed DowneyTung closed 5 years ago

DowneyTung commented 5 years ago

Currently, if I want to run a test related to flash applications, there is no easy way I can do it. Recently, I figured a way to add PepperFlashPlugin on top of the elgalu/selenium image, just wonder is it possible to add those extra RUN command as part of the image building process?

RUN sudo apt-get update && sudo apt-get install -y software-properties-common
RUN sudo apt-get update && sudo add-apt-repository ppa:jonathonf/pepperflashplugin-nonfree
RUN sudo apt update
RUN sudo apt install -y pepperflashplugin-nonfree
RUN sudo update-pepperflashplugin-nonfree --install
RUN sudo apt -y install browser-plugin-freshplayer-pepperflash

This request is related to this post https://github.com/zalando/zalenium/issues/497

elgalu commented 5 years ago

it says nonfree so doesn't look like we are allowed to include it

DowneyTung commented 5 years ago

@elgalu so you are concerned that we have to pay for it since if it said nonfree ? I did that on my local machine and did not notice any payment requirement....

diemol commented 5 years ago

I think we should not add this, as I mentioned in a Slack comment, I think @DowneyTung is the 2nd person ever to ask about flash. So my opinion is that we should keep the least amount of things in the images so they can be extended at will, but also to not increase maintenance.

diemol commented 5 years ago

Closing as no further actions will be performed.