elgarfo / mintty

Automatically exported from code.google.com/p/mintty
GNU General Public License v3.0
0 stars 0 forks source link

OSC sequence breaks when use the multibyte string #106

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. run osc_bad.sh (attached file) on UTF-8 codepage.

What is the expected output? What do you see instead?
I expected that all the text is displayed in the window title.
But it tore the text.

What version of the product are you using? On what operating system?
trunk (rev.312) / Windows XP (SP3)

Please provide any additional information below.
osc.patch (attached file) fix this problem.

Original issue reported on code.google.com by deenhe...@gmail.com on 11 May 2009 at 3:09

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed in r313 on 0.4 branch. Thanks for another excellent bug report!

Original comment by andy.koppe on 11 May 2009 at 6:37

GoogleCodeExporter commented 9 years ago

Original comment by andy.koppe on 7 Jun 2009 at 7:57

GoogleCodeExporter commented 9 years ago
Reopen.

"otherwise" part is not executed when c == 0234 && term_in_utf() is true.

Original comment by deenhe...@gmail.com on 1 Jul 2009 at 12:56

Attachments:

GoogleCodeExporter commented 9 years ago
Ouch, that must have been a pain to track down. Thank you very much!

Fixed in r408 on 0.4 branch, by removing support for the C1 version of the ST 
(string
termination) code altogether, because it interfered with Windows codepages as 
well
and I'd already removed support for C1 control characters more generally.

(What were they thinking anyway when they wasted 32 valuable code positions on 
the C1
control characters while the majority of the C0 codes are unused?)

Original comment by andy.koppe on 1 Jul 2009 at 7:19