[REQUEST] Option to manually add image link

sk8ordi3 commented 8 months ago

Expected Behavior

Display the image even if the poster link is manually specified

Current Behavior

The image link manually passed to the element does not appear during playback

Possible Solution

for the soultion: possible to add to elementum, what @GladistonXD find here: [link](https://github.com/elgatito/plugin.video.elementum/issues/886#issuecomment-1229691428)

[navigation.py](https://github.com/elgatito/plugin.video.elementum/blob/a3e1bed8489344518de32421ba373c6956bfa8db/resources/site-packages/elementum/navigation.py#L218-L228) after modifications in the navigation.py file, the manually added image will be displayed perfectly during playback.

the changes use 'or' so it would not affect the previous operation but could be used if someone manually added an image

Environment name and version: Elementum 0.1.99
Operating System and version: Windows 10: Kodi V21 Omega Android: Kodi V21 Omega

elgatito commented 8 months ago

@sk8ordi3 I do not understand what you exactly want. What do you mean by "manually add"? Add what and where and what you expect?

sk8ordi3 commented 8 months ago

@sk8ordi3 I do not understand what you exactly want. What do you mean by "manually add"? Add what and where and what you expect?

after changes in navigation.py we can use setArt to displaying the poster

    def playMovie(self, url, poster_link):
        play_item = xbmcgui.ListItem(path=url)

        play_item.setArt({"poster": poster_link})

        xbmcplugin.setResolvedUrl(syshandle, True, listitem=play_item)

GladistonXD commented 8 months ago

@sk8ordi3 I do not understand what you exactly want. What do you mean by "manually add"? Add what and where and what you expect?

In this case it would be importing arts/images from external codes outside of elementum with individual addons, I made this possible solution in the example, then I had to program my addon to replace this line when starting, as the official one doesn't have this function yet, I already gave this idea is 2 years old https://github.com/elgatito/plugin.video.elementum/issues/886. 😅

elgatito commented 8 months ago

@GladistonXD It I understand your solution - it would just take currently selected item and use it for Player info.

But if you would be in a Youbute, for example, and start a playback remotely - you would have information from that Youtube selected item. Right?

elgatito commented 8 months ago

we can use setArt to displaying the poster

You have not answered what you want to achieve and why.

GladistonXD commented 8 months ago

@GladistonXD It I understand your solution - it would just take currently selected item and use it for Player info.

But if you would be in a Youbute, for example, and start a playback remotely - you would have information from that Youtube selected item. Right?

Yes, on YouTube, yes, the problem is when using the plugin://plugin.video.elementum/play?uri="+magnet to launch a code magnet outside the elementum, it only captures the setInfo, the SetArt is not captured, only I managed to capture it, I changed the code to pull via xbmc.getInfoLabel("ListItem.Art(poster)")

GladistonXD commented 8 months ago

The image above is what it looks like without this modification, and the one below is as expected.

elgatito commented 8 months ago

@GladistonXD

it only captures the setInfo, the SetArt is not captured, only I managed to capture it, I changed the code to pull via xbmc.getInfoLabel("ListItem.Art(poster)")

But how you get other infolabels into Player?

They idea is that when player is started, it gets mediatype information with id (like "Movie" + TMDB ID), then navigation.py is doing request to Elementum asking to give infolabels for that media item (if possible).

That is why once you start something externally - it does not have any infolabels, only the file name or torrent name (as that is the only thing we know).

Question is how you start player. By calling with plugin path, or by calling Elementum's Python method directly to start a player?

elgatito commented 8 months ago

The image above is what it looks like without this modification, and the one below is as expected.

That is interesting. Where it gets description? Can you give a step-by-step how I can reproduce on my side?

GladistonXD commented 8 months ago

Question is how you start player. By calling with plugin path, or by calling Elementum's Python method directly to start a player?

Yes, I understand, but in this case, films for which there is no TMDB information are not shown despite the information being included directly from the source:

     listem = xbmcgui.ListItem()
     listem.setLabel(name)
     listem.setInfo(type="video", infoLabels={"mediatype": "movie", "Title": name, "Plot": info})
     listem.setArt({"thumb": iconimage,"poster": iconimage,"tvshowposter": iconimage,"banner": iconimage,"fanart":      iconimage,"clearart": iconimage,"clearlogo": iconimage,"landscape" : iconimage,"icon": iconimage})

So I made this change to the source code to capture both:

item.setArt({
     "thumb": _infoLabels["artthumb"] or xbmc.getInfoLabel("ListItem.Art(thumb)"),
     "poster": _infoLabels["artposter"] or xbmc.getInfoLabel("ListItem.Art(poster)"),
     "tvshowposter": _infoLabels["arttvshowposter"] or xbmc.getInfoLabel("ListItem.Art(tvshowposter)"),
     "banner": _infoLabels["artbanner"] or xbmc.getInfoLabel("ListItem.Art(banner)"),
     "fanart": _infoLabels["artfanart"] or xbmc.getInfoLabel("ListItem.Art(fanart)"),
     "clearart": _infoLabels["artclearart"] or xbmc.getInfoLabel("ListItem.Art(clearart)"),
     "clearlogo": _infoLabels["artclearlogo"] or xbmc.getInfoLabel("ListItem.Art(clearlogo)"),
     "landscape": _infoLabels["artlandscape"] or xbmc.getInfoLabel("ListItem.Art(landscape)"),
     "icon": _infoLabels["articon"] or xbmc.getInfoLabel("ListItem.Art(icon)")
})

GladistonXD commented 8 months ago

The image above is what it looks like without this modification, and the one below is as expected.

That is interesting. Where it gets description? Can you give a step-by-step how I can reproduce on my side?

Yes, I'm going to create an example of this situation, just a minute.

elgatito commented 8 months ago

@GladistonXD I think we are getting closer to the end :)

When player is opening something without TMDB ID, then it goes for /infolabels and gets all the infolabelss from Kodi and proxies them to navigation.py. List of labels we get from Kodi: https://github.com/elgatito/elementum/blob/master/api/infolabels.go#L23-L60

So the question is whether we get wrong labels from Kodi, that do not include Art labels (if you say that your ListItem has correct Art items), or we are not properly processing those labels later in navigation.py.

Because what you do with your change - it what is already done in infolabels.go where we get ListItem info from Kodi.

GladistonXD commented 8 months ago

The execution is more or less this:

name = 'Dune 2'
url = 'plugin://plugin.video.elementum/play?uri=magnet:?xt=urn:btih:5B98EEDABB780D1FF58C8A8D5AFB6C234B10757E'
iconimage = 'https://image.tmdb.org/t/p/w342/8LJJjLjAzAwXS40S5mx79PJ2jSs.jpg'
info = 'Paul Atreides (Timothée Chalamet) teams up with Chani (Zendaya) and the Fremen as he seeks revenge...'

item = xbmcgui.ListItem(name, path=url)
item.setInfo('video', infoLabels={'Title': name, 'plot': info})
item.setArt({'thumb': iconimage,'poster': iconimage, 'fanart': iconimage, "icon": iconimage})
xbmcplugin.setResolvedUrl(int(sys.argv[1]), True, item)

@elgatito

GladistonXD commented 8 months ago

@GladistonXD I think we are getting closer to the end :)

When player is opening something without TMDB ID, then it goes for /infolabels and gets all the infolabelss from Kodi and proxies them to navigation.py. List of labels we get from Kodi: https://github.com/elgatito/elementum/blob/master/api/infolabels.go#L23-L60

So the question is whether we get wrong labels from Kodi, that do not include Art labels (if you say that your ListItem has correct Art items), or we are not properly processing those labels later in navigation.py.

Because what you do with your change - it what is already done in infolabels.go where we get ListItem info from Kodi.

Yes, he receives the titles, just not the images And how would it be used directly in the example code I sent?

elgatito commented 8 months ago

And how would it be used directly in the example code I sent?

When you send anything to /play it would trigger call to /infolabels to get labels. You can check Kodi logs to see is there is a request to /infolabels and can place log messages after this line https://github.com/elgatito/plugin.video.elementum/blob/a3e1bed8489344518de32421ba373c6956bfa8db/resources/site-packages/elementum/navigation.py#L199 to see what labels are received and used to set in navigation.py

GladistonXD commented 8 months ago

And how would it be used directly in the example code I sent?

When you send anything to /play it would trigger call to /infolabels to get labels. You can check Kodi logs to see is there is a request to /infolabels and can place log messages after this line

https://github.com/elgatito/plugin.video.elementum/blob/a3e1bed8489344518de32421ba373c6956bfa8db/resources/site-packages/elementum/navigation.py#L199

to see what labels are received and used to set in navigation.py

2024-03-08 13:32:36.608 T:7596  warning <general>: [plugin.video.elementum] [GIN] 2024/03/08 - 13:32:36 | 404 |            0s |       127.0.0.1 | GET      "/infolabels"

plugin://plugin.video.filmes/?name=[COLOR+springgreen][B][COLOR+springgreen][B]Dublado+R5+[/B][/COLOR]&url=magnet:?xt=urn:btih:5B98EEDABB780D1FF58C8A8D5AFB6C234B10757E&dn=Dune.Part.Two.2024.1080p.HDCAM.Dublado.V.2.mkv&tr=udp%3a%2f%2ftracker.openbittorrent.com%3a80%2fannounce&tr=udp%3a%2f%2ftracker.opentrackr.org%3a1337%2fannounce&tr=wss%3a%2f%2fwstracker.online&mode=521&iconimage=https://image.tmdb.org/t/p/w342/8LJJjLjAzAwXS40S5mx79PJ2jSs.jpg&logos=https://image.tmdb.org/t/p/w342/8LJJjLjAzAwXS40S5mx79PJ2jSs.jpg&cache=0&info=+Paul+Atreides+(Timothée+Chalamet)+se+une+a+Chani+(Zendaya)+e+aos+Fremen+enquanto+busca+vingança+contra+os+conspiradores+que+destruíram+sua+família.+Uma+jornada+espiritual,+mística+e+marcial+se+inicia.+Para+se+tornar+Muad’Dib,+enquanto+tenta+prevenir+o+futuro+horrível,+mas+inevitável+que+ele+testemunhou,+Paul+Atreides+vê+uma+Guerra+Santa+em+seu+nome,+espalhando-se+por+todo+o+universo+conhecido.+Enfrentando+uma+escolha+entre+o+amor+de+sua+vida+e+o+destino+do+universo,+Paul+deve+evitar+um+futuro+terrível+que+só+ele+pode+prever.+Se+tudo+sair+como+planejado,+ele+poderá+guiar+a+humanidade+para+um+futuro+promissor.&background=Duna:+Parte+2+(2024)+Dublado+Oficial+/+Legendado+HDCAM+1080p&legdub=[COLOR+springgreen][B][COLOR+springgreen][B]Dublado+R5+&metah=

2024-03-08 13:32:36.634 T:20284    info <general>: Creating InputStream
2024-03-08 13:32:36.646 T:20284    info <general>: Creating Demuxer
2024-03-08 13:32:36.677 T:20284    info <general>: Opening stream: 0 source: 256
2024-03-08 13:32:36.677 T:20284    info <general>: Creating video codec with codec id: 27
2024-03-08 13:32:36.677 T:20284    info <general>: CDVDVideoCodecFFmpeg::Open() Using codec: H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10
2024-03-08 13:32:36.677 T:20284    info <general>: Creating video thread
2024-03-08 13:32:36.677 T:17436    info <general>: running thread: video_thread
2024-03-08 13:32:36.677 T:20284    info <general>: Opening stream: 1 source: 256
2024-03-08 13:32:36.677 T:20284    info <general>: Finding audio codec for: 86018
2024-03-08 13:32:36.677 T:20284    info <general>: CDVDAudioCodecFFmpeg::Open() Successful opened audio decoder aac
2024-03-08 13:32:36.677 T:20284    info <general>: CVideoPlayerAudio::OpenStream: Allowing max Out-Of-Sync Value of 10 ms
2024-03-08 13:32:36.677 T:20284    info <general>: Creating audio thread
2024-03-08 13:32:36.678 T:19084    info <general>: running thread: CVideoPlayerAudio::Process()
2024-03-08 13:32:36.678 T:20284    info <general>: Opening stream: 0 source: 1024
2024-03-08 13:32:36.678 T:20284   error <general>: CVideoPlayerSubtitle::OpenStream - Unable to create subtitle parser
2024-03-08 13:32:36.678 T:20284    info <general>: Opening stream: 0 source: 1025
2024-03-08 13:32:36.678 T:20284   error <general>: CVideoPlayerSubtitle::OpenStream - Unable to create subtitle parser
2024-03-08 13:32:36.678 T:20284    info <general>: Opening stream: 0 source: 1026
2024-03-08 13:32:36.678 T:20284   error <general>: CVideoPlayerSubtitle::OpenStream - Unable to create subtitle parser
2024-03-08 13:32:36.678 T:20284    info <general>: Opening stream: 0 source: 1027
2024-03-08 13:32:36.678 T:20284   error <general>: CVideoPlayerSubtitle::OpenStream - Unable to create subtitle parser
2024-03-08 13:32:36.688 T:17436    info <general>: CDVDVideoCodecFFmpeg::Open() Using codec: H.264 / AVC / MPEG-4 AVC / MPEG-4 part 10
2024-03-08 13:32:36.688 T:19084    info <general>: Creating audio stream (codec id: 86018, channels: 2, sample rate: 48000, no pass-through)
2024-03-08 13:32:36.714 T:21752    info <general>: CActiveAESink::OpenSink - initialize sink
2024-03-08 13:32:36.760 T:7596  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ Open             Opening \Dune.Part.Two.2024.1080p.HDCAM.Dublado.V.2.mkv
2024-03-08 13:32:36.824 T:6304  warning <general>: CGUIWindowManager - CGUIWindowManager::HandleAction - ignoring action 107, because topmost modal dialog closing animation is running
2024-03-08 13:32:36.904 T:7596     info <general>: Skipped 1 duplicate messages..
2024-03-08 13:32:36.904 T:7596  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ Open             \Dune.Part.Two.2024.1080p.HDCAM.Dublado.V.2.mkv belongs to torrent Dune.Part.Two.2024.1080p.HDCAM.Dublado.V.2.mkv
2024-03-08 13:32:36.904 T:7596  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ ResetReaders     Setting readahead for reader 1709915556633545700 as 4.2 MB
2024-03-08 13:32:36.904 T:7596  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ Close            Closing file...
2024-03-08 13:32:36.904 T:7596  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ Open

In this case, these logs?

GladistonXD commented 8 months ago

The execution is more or less this:

name = 'Dune 2'
url = 'plugin://plugin.video.elementum/play?uri=magnet:?xt=urn:btih:5B98EEDABB780D1FF58C8A8D5AFB6C234B10757E'
iconimage = 'https://image.tmdb.org/t/p/w342/8LJJjLjAzAwXS40S5mx79PJ2jSs.jpg'
info = 'Paul Atreides (Timothée Chalamet) teams up with Chani (Zendaya) and the Fremen as he seeks revenge...'

item = xbmcgui.ListItem(name, path=url)
item.setInfo('video', infoLabels={'Title': name, 'plot': info})
item.setArt({'thumb': iconimage,'poster': iconimage, 'fanart': iconimage, "icon": iconimage})
xbmcplugin.setResolvedUrl(int(sys.argv[1]), True, item)

@elgatito

In this case I use an addon called plugin://plugin.video.filmes and I direct the information to elementum in this way, and without this modification I cannot capture the images when the play is launched, I only get title and description information.

elgatito commented 8 months ago

In this case I use an addon called plugin://plugin.video.filmes

Can you share zip file for that plugin? I cannot find exact source for that plugin.

GladistonXD commented 8 months ago

Can you share zip file for that plugin? I cannot find exact source for that plugin.

I'm going to create an addon with this specific issue and then send the zip here.

GladistonXD commented 8 months ago

plugin.video.filmes.zip I made an addon to check the situation. @elgatito

elgatito commented 8 months ago

plugin.video.filmes.zip I made an addon to check the situation. @elgatito

It saved me lot of time in testing. Thanks.

I pushed a change to Elementum code (https://github.com/elgatito/elementum/commit/6808610e5f60a9af89375aed59713f5b303c78dd) You can build and test on your end, or wait for new version to be released.

It shows all the information and images with your test addon. No python code changes are needed.

GladistonXD commented 8 months ago

plugin.video.filmes.zip I made an addon to check the situation. @elgatito

It saved me lot of time in testing. Thanks.

I pushed a change to Elementum code (elgatito/elementum@6808610) You can build and test on your end, or wait for new version to be released.

It shows all the information and images with your test addon. No python code changes are needed.

Ok I'll test it, thanks for your work. 😄

antonsoroko commented 8 months ago

@GladistonXD were you able to build a test version of elementum? docs - https://github.com/elgatito/plugin.video.elementum?tab=readme-ov-file#build

if not - tell me your platform (e.g. windows_x64, see https://github.com/elgatito/plugin.video.elementum/releases) and i can make a test build for you.

sk8ordi3 commented 7 months ago

@antonsoroko i saw where elgatito pushed that is some go version of elementum i would like to request the windows_x64 build version for testing

GladistonXD commented 7 months ago

@GladistonXD were you able to build a test version of elementum? docs - https://github.com/elgatito/plugin.video.elementum?tab=readme-ov-file#build

if not - tell me your platform (e.g. windows_x64, see https://github.com/elgatito/plugin.video.elementum/releases) and i can make a test build for you.

I didn't compile it to test, it could be windows_x64

antonsoroko commented 7 months ago

@sk8ordi3 @GladistonXD

windows_x64 build of master branch - plugin.video.elementum-v0.1.99-31-gbc63d8e.windows_x64.zip

(be aware that it has many other unreleased features, so it is expected that some things are different than in 0.1.99.)

GladistonXD commented 7 months ago

@sk8ordi3 @GladistonXD

windows_x64 build of master branch - plugin.video.elementum-v0.1.99-31-gbc63d8e.windows_x64.zip

(be aware that it has many other unreleased features, so it is expected that some things are different than in 0.1.99.)

It worked perfectly, it also removed the bug where the name episode 0* always appeared in front of the title before I used alternative like this 'play?show=""&uri=' to remove this bug. thanks

GladistonXD commented 7 months ago

I found a problem in this beta version, when the torrent has several episodes embedded, the panel does not open, for example: magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d, notifying you in case it is released in the official version. @elgatito @antonsoroko

elgatito commented 7 months ago

@GladistonXD What do you mean? You add a magnet with multiple files and do not get a dialog to select which file to play? Can you show a log?

GladistonXD commented 7 months ago

@GladistonXD What do you mean? You add a magnet with multiple files and do not get a dialog to select which file to play? Can you show a log?

Yes of course, I believe it is in the Dialog Select part This problem only occurred in this trial version:

2024-04-05 03:04:25.305 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ AddTorrent       Adding torrent from magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.305 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ AddTorrent       Setting save path to .
2024-04-05 03:04:25.305 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        add_torrent_alert: added torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.305 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        state_changed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d: state changed to: dl metadata
2024-04-05 03:04:25.305 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        torrent_resumed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d resumed
2024-04-05 03:04:25.309 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ AddTorrent       Setting sequential download to: false
2024-04-05 03:04:25.309 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ AddTorrent       Adding new torrent item with url: magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:25.309 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ NewTorrent       Adding torrent with storage: Memory
2024-04-05 03:04:25.310 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ WaitForMetadata  Waiting for information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:26.323 T:8480  warning <general>: [plugin.video.elementum] INFO Init with mem size 419430400, Pieces: 6600, Piece length: 8388608
2024-04-05 03:04:26.323 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ WaitForMetadata  Information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d
2024-04-05 03:04:26.323 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        metadata_received_alert: Uma Familia da Pesada metadata successfully received
2024-04-05 03:04:26.323 T:8480  warning <general>: [plugin.video.elementum] INFO Using 52 buffers
2024-04-05 03:04:26.382 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        state_changed_alert: Uma Familia da Pesada: state changed to: finished
2024-04-05 03:04:26.382 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        torrent_finished_alert: Uma Familia da Pesada torrent finished downloading
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        state_changed_alert: Uma Familia da Pesada: state changed to: checking (r)
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        state_changed_alert: Uma Familia da Pesada: state changed to: finished
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        torrent_finished_alert: Uma Familia da Pesada torrent finished downloading
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        torrent_checked_alert: Uma Familia da Pesada checked
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ addTorrent       Downloading Uma Familia da Pesada
2024-04-05 03:04:26.383 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ GetCandidateFiles  There are 222 candidate files
2024-04-05 03:04:26.389 T:2108     info <general>: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2024-04-05 03:04:26.417 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ playerLoop       Buffer loop
2024-04-05 03:04:26.681 T:8480  warning <general>: [plugin.video.elementum] ERRO  reqapi       ▶ func2            Bad status getting movie with map[api_key:[29a551a65eef108dd01b46e27eb0554a] append_to_response:[credits,images,alternative_titles,translations,external_ids,trailers,release_dates] include_image_language:[pt,en,null] include_video_language:[pt,en,null] language:[pt]] on https://api.themoviedb.org/3/movie/0: 404/404 Not Found
2024-04-05 03:04:26.683 T:964   critical <general>: [plugin.video.elementum] (elementum.rpc) In Handler method ElementumRPCServer.Dialog_Select('LOCALIZE[30560];;', ['UFDP.S01.720p....) 
2024-04-05 03:04:26.686 T:964   critical <general>: [plugin.video.elementum] Unhandled error: TypeError: Dialog_Select() missing 2 required positional arguments: 'autoclose' and 'preselect'
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] ERRO  bittorrent   ▶ playerLoop       Error buffering: &errors.errorString{s:"User cancelled"}
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ RemoveTorrent    Removing torrent: Uma Familia da Pesada
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ Drop             Dropping torrent: Uma Familia da Pesada
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ func1            Removing the torrent without deleting files after playing ...
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] NOTI  bittorrent   ▶ logAlerts        torrent_removed_alert: Uma Familia da Pesada removed
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ func1            Deleting storage type file at ...\AppData\Roaming\Kodi\cache\elementum_torrents\.a6dc9a0a59ad352d66775b323fc305b1813dce0d.memory
2024-04-05 03:04:26.686 T:8480  warning <general>: [plugin.video.elementum] INFO  bittorrent   ▶ func1            Removed Uma Familia da Pesada from database

elgatito commented 7 months ago

And what Kodi version is that?

пт, 5 апр. 2024 г., 08:13 GladistonXD @.***>:

@GladistonXD https://github.com/GladistonXD What do you mean? You add a magnet with multiple files and do not get a dialog to select which file to play? Can you show a log?

Yes of course, I believe it is in the Dialog Select part This problem only occurred in this trial version:

2024-04-05 03:04:25.305 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ AddTorrent 2024-04-05 03:04:25.305 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ AddTorrent 2024-04-05 03:04:25.305 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:25.305 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:25.305 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:25.309 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ AddTorrent 2024-04-05 03:04:25.309 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ AddTorrent 2024-04-05 03:04:25.309 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ NewTorrent 2024-04-05 03:04:25.310 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ WaitForMetadata 2024-04-05 03:04:26.323 T:8480 warning : [plugin.video.elementum] INFO Init with mem size 2024-04-05 03:04:26.323 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ WaitForMetadata 2024-04-05 03:04:26.323 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.323 T:8480 warning : [plugin.video.elementum] INFO Using 52 buffers 2024-04-05 03:04:26.382 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.382 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ addTorrent 2024-04-05 03:04:26.383 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ GetCandidateFiles 2024-04-05 03:04:26.389 T:2108 info : Loading skin file: DialogConfirm.xml, load type: 2024-04-05 03:04:26.417 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ playerLoop 2024-04-05 03:04:26.681 T:8480 warning : [plugin.video.elementum] ERRO reqapi ▶ func2 2024-04-05 03:04:26.683 T:964 critical : [plugin.video.elementum] (elementum.rpc) In Handler 2024-04-05 03:04:26.686 T:964 critical : [plugin.video.elementum] Unhandled error: TypeError: 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] ERRO bittorrent ▶ playerLoop 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ RemoveTorrent 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ Drop 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ func1 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] NOTI bittorrent ▶ logAlerts 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ func1 2024-04-05 03:04:26.686 T:8480 warning : [plugin.video.elementum] INFO bittorrent ▶ func1 Adding torrent from magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d Setting save path to . add_torrent_alert: added torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d state_changed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d: state changed to: dl metadata torrent_resumed_alert: a6dc9a0a59ad352d66775b323fc305b1813dce0d resumed Setting sequential download to: false Adding new torrent item with url: magnet:?xt=urn:btih:a6dc9a0a59ad352d66775b323fc305b1813dce0d Adding torrent with storage: Memory Waiting for information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d 419430400, Pieces: 6600, Piece length: 8388608 Information fetched for torrent: a6dc9a0a59ad352d66775b323fc305b1813dce0d metadata_received_alert: Uma Familia da Pesada metadata successfully received state_changed_alert: Uma Familia da Pesada: state changed to: finished torrent_finished_alert: Uma Familia da Pesada torrent finished downloading state_changed_alert: Uma Familia da Pesada: state changed to: checking (r) state_changed_alert: Uma Familia da Pesada: state changed to: finished torrent_finished_alert: Uma Familia da Pesada torrent finished downloading torrent_checked_alert: Uma Familia da Pesada checked Downloading Uma Familia da Pesada There are 222 candidate files KEEP_IN_MEMORY Buffer loop Bad status getting movie with map[api_key:[29a551a65eef108dd01b46e27eb0554a] append_to_response:[credits,images,alternative_titles,translations,external_ids,trailers,release_dates] include_image_language:[pt,en,null] include_video_language:[pt,en,null] language:[pt]] on https://api.themoviedb.org/3/movie/0: 404/404 Not Found method ElementumRPCServer.Dialog_Select('LOCALIZE[30560];;', ['UFDP.S01.720p....) Dialog_Select() missing 2 required positional arguments: 'autoclose' and 'preselect' Error buffering: &errors.errorString{s:"User cancelled"} Removing torrent: Uma Familia da Pesada Dropping torrent: Uma Familia da Pesada Removing the torrent without deleting files after playing ... torrent_removed_alert: Uma Familia da Pesada removed Deleting storage type file at ...\AppData\Roaming\Kodi\cache\elementum_torrents.a6dc9a0a59ad352d66775b323fc305b1813dce0d.memory Removed Uma Familia da Pesada from database

— Reply to this email directly, view it on GitHub https://github.com/elgatito/plugin.video.elementum/issues/1002#issuecomment-2039023032, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJQQCUZWBSFF6GUUKKB4XTY3Y6IDAVCNFSM6AAAAABEMS2HDCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMZZGAZDGMBTGI . You are receiving this because you were mentioned.Message ID: @.***>

GladistonXD commented 7 months ago

And what Kodi version is that?

v20.5 Windows x64

antonsoroko commented 7 months ago

(elementum.rpc) In Handler method ElementumRPCServer.Dialog_Select('LOCALIZE[30560];;', ['UFDP.S01.720p....) 
Unhandled error: TypeError: Dialog_Select() missing 2 required positional arguments: 'autoclose' and 'preselect'

@elgatito

There was change in Dialog_Select() for new language select functionality , iirc. I guess either the test build does not have some needed changes or python/golang code was not updated in some place about file selection.

elgatito commented 7 months ago

@antonsoroko @GladistonXD I fixed that issue in the latest code.

antonsoroko commented 7 months ago

@GladistonXD i have not tested this but here is a new build for you to test: plugin.video.elementum-v0.1.99-43-g5e99c5d.windows_x64.zip

GladistonXD commented 6 months ago

@GladistonXD i have not tested this but here is a new build for you to test: plugin.video.elementum-v0.1.99-43-g5e99c5d.windows_x64.zip

I ran the tests, now everything is working perfectly.

elgatito / plugin.video.elementum