elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
483 stars 159 forks source link

RFC: Try to use translations from Trakt, to improve ForceUseTrakt option #1004

Open antonsoroko opened 7 months ago

antonsoroko commented 7 months ago

Expected Behavior

Not a bug but a Request for Comments.

Looks like Trakt now supports translations: https://trakt.docs.apiary.io/#reference/shows/updated-ids/get-all-movie-translations

so we can try to use translations from Trakt - it will be useful for ForceUseTrakt=true - so for Trakt lists we also will have localization (now it is always in english).

although, i am not sure how valuable is this: even with ForceUseTrakt=true we still go to TMBD for images so it is not faster than ForceUseTrakt=false, it just sometimes have better info (like proper "air date"), and some own info (like "rating").

I guess long time ago (when Trakt provided images) ForceUseTrakt was added to speed up rendering: https://github.com/elgatito/elementum/commit/7fc6147606508a32e42edd3abd36c704c52d2874

Current Behavior

Possible Solution

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

elgatito commented 7 months ago

I guess long time ago (when Trakt provided images) ForceUseTrakt was added to speed up rendering:

I can't recall if Trakt was ever providing images through API.

Looks like Trakt now supports translations:

Yes, looks they added translations. But you need to make a separate request to get title/description for your desired language, so it is a separate request per each item. But it can be called only if non-"en" language needed and called to return only required translation (not all of them).

although, i am not sure how valuable is this:

Yes. That is a main question. One thing is not having descriptions/titles localized at all, another is having both and considering source of data to use.