Saderius
commented
7 months ago First of all, I think you are making wrong assumptions.
first of all, TMDB is not affiliated with elementum/kodi and vice versa. i have an impression that you confuse TMDB (web site) and Kodi's local DB.
No I'm not, and that is the point I'm trying to make.
we do not do any exceptions about specific titles in code. we try to use romaji (b/c of the reason i described above) if it was added to TMDB by users. but of course, since romaji is not real/official language - it can have mistakes (and TMDB does not have strict moderation, so mistakes can easily slip into DB). but in my experience for the vast majority of titles romaji is correct in TMDB. no idea where you get "for every single title".
opposing to
maybe we should use first alternative title, not last
I provided examples, titles included in db were correct (just not in the "right" place), search took wrong names. Every single title (I provided example of AND based solely on that I could probably give you anorther 20 in under 10 min).
and as you wrote before
- so if you take a look into log file you will see that last "row" for Romaji is used (which is logical). Code logic is here https://github.com/elgatito/elementum/blob/0c5c77eb80f10554e4be2461df57034edc9246aa/providers/xbmc.go#L376
It is logical in terms "code works as was written", but irrational in terms "as expected". I see it as flawed and unrefined.
if user see that something is wrong in TMDB - user can fix it, for all users. again - there is not magic. if you have not added new movie but you see it - it just means that someone else added it. but if you see that something is missing - that means than nobody added it and you can be a pioneer.
I'm pretty sure you are confusing here "all users" with "all users of kodi wchich use elementum addon to watch anime", wchich is friction probably so small to the whole database it becomes vastly insignificant in the whole. Adding duplicates or moving titles around just for the in-app seach to work (i'll say it again) sounds like madness. Besides that, no magic in db -> magic in code.
changing title only in your local kodi's db - this can be considered as a solution, but it is hacky and awkward solution. it is not how it "should work", it is a "hack". maybe it is reasonable hack, but still.
As hacky and awkward as [torrent-sharing.naming///convention] is, so feels about right.
in the end, i do not see a big difference between changing title in TMDB and changing title in Kodi's DB. i would prefer if people would fix thing for everyone, not only for themselves.
again, everyone ≠ "all users of kodi wchich use elementum addon to watch anime". Again, if not user provided, then WARNING MULTIPLE TITLES DETECTED -> "pick title to use from TMDB listing" sounds resonable. Well, way better than 0 results from 8 providers when I know for a fact they're there.
in my opinion - the robust solution would be to use some well known Anime API to get Romaji title that was moderated by some trustworthy person who is profound in anime world. Which again mean that someone (instead of other users or you) would add correct Romaji title and then would let anyone to use his/her work. but we heavily use TMDB which means that for us it would be ideal to use some anime api that can find anime by tmdb id. but i do not see such api: https://publicapi.dev/category/anime?page=1 which means that we need to do search by english/japanese title from TMDB and then hope that we found correct anime (which would be impossible sometimes, since sites like myanimelist split one anime into several animes based on seasons, example), so then we can use Romaji provided by this 3rd party API (and again we can only hope that their Romaji is correct). so it is not perfect solution. with all this info - maybe "changing title only in your local kodi's db" is not that bad solution. if user did something wrong (e.g. typed wrong title) - it is problem of that particular user (if user will make the same mistake in TMDB - it would be problem for everyone).
I could make a bet, with current approach it would born the same issues. I see no point in changing what isn't broken (API). So here we kinda agree that it's not an issue of database nor quite titles provided by it in general.
anyway, speaking for myself: right now i do not have desire to implement "integration with anime api" or "manual change title in kodi db" features.
and that is totally fine. You are a person, not a nonamed-robot.
In the end, let's state what we know for certain.
- API used from TMDB is enough.
- Anime searching is a problem due to existance of Romanji.
- There is no wastly accepted naming convention for torrent sharing.
- "ALL USERS" ≠ "all users of".
ad 2 the same title can have multiple instances of "correct" in Romanji. I see my issue and input are not first on the subject thus far ad 3 even the same file can have different names (Romanji or not, user error, whatever) from the same provider
antonsoroko
elgatito
Anime torrent releases use romaji instead of english. Currently we use TMDB as source of info for anime. If TMDB has Romaji title (added by users) then we use it. But romaji itself can be spelled differently (as i can see) or it can be that no one added it. It this case user can go to TMDB and fix this. But i guess only experienced users are willing to do this.
Thus 2 solutions:
full discussion is here https://github.com/elgatito/script.elementum.burst/issues/387#issuecomment-2070807547
summary:
TMDB is user driver database. users populate the database. for tv shows and movies it works perfect (or near to perfect). for anime it works not so good, since torrent releases use romaji instead of english and romaji itself can be spelled differently (as i can see).
we try to use romaji (b/c of the reason i described above) if it was added to TMDB by users. but of course, since romaji is not real/official language - it can have mistakes (and TMDB does not have strict moderation, so mistakes can easily slip into DB). but in my experience for the vast majority of titles romaji is correct in TMDB. no idea where you get "for every single title".
if user see that something is wrong in TMDB - user can fix it, for all users. again - there is not magic. if you have not added new movie but you see it - it just means that someone else added it. but if you see that something is missing - that means than nobody added it and you can be a pioneer.
changing title only in your local kodi's db - this can be considered as a solution, but it is hacky and awkward solution. maybe it is reasonable hack, but still.
in the end, i do not see a big difference between changing title in TMDB and changing title in Kodi's DB. i would prefer if people would fix thing for everyone, not only for themselves.
in my opinion - the robust solution would be to use some well known Anime API to get Romaji title that was moderated by some trustworthy person who is profound in anime world. Which again mean that someone (instead of other users or you) would add correct Romaji title and then would let anyone to use his/her work.
but we heavily use TMDB which means that for us it would be ideal to use some anime api that can find anime by tmdb id. but i do not see such api: https://publicapi.dev/category/anime?page=1 which means that we need to do search by english/japanese title from TMDB and then hope that we found correct anime (which would be impossible sometimes, since sites like myanimelist split one anime into several animes based on seasons, example), so then we can use Romaji provided by this 3rd party API (and again we can only hope that their Romaji is correct). so it is not perfect solution.
with all this info - maybe "changing title only in your local kodi's db" is not that bad solution. if user did something wrong (e.g. typed wrong title) - it is problem of that particular user (if user will make the same mistake in TMDB - it would be problem for everyone).