search

elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
477 stars 157 forks source link

Download movies to seperate folders #1060

Open VisionaiR3D opened 1 week ago

VisionaiR3D commented 1 week ago

Elementum used to download files to seperate folders, with each folder named after the movie title. Nowadays it still does this for tvshows. But it dumps all movies in the same folder.

I'm using Nvidia shield on android.

Expected behavior Download the movie batman from Tim Burton to \movies\batman (1989)\batman.mkv

Behavior It downloads the movie to \movies\batman.mkv

It would keep things more organized.

antonsoroko commented 2 days ago

@VisionaiR3D

Elementum used to download files to seperate folders, with each folder named after the movie title.

i do not remember such option and i can't find such code or leftovers of such code. maybe previously you downloaded only torrents that already had top level folder thus you got the impression that it is elementum who created such folder.

~same for tv shows. but for tv shows torrents it is standard to have top level folder.~ for tv show, if you enabled "move on complete" - there is code to create new folder.

try to use any desktop bittorrent client to see how different torrents are organised.

this can be a "feature request" in case if someone will have desire to implement it.

but if course i might be wrong and many years ago elementum had such option. (although such option would not work for manual torrent search (without TMDB info) for obvious reasons.)

VisionaiR3D commented 1 day ago

Yes well it was a long time ago. I believe it might have been around 0.1.87 when it was a feature.

antonsoroko commented 1 day ago

@VisionaiR3D I see. I will take a look into old code "snapshot".

antonsoroko commented 1 day ago

@VisionaiR3D so i do not see any code for movies about what you said. related code logic was not changed for last 7 years.

but for tv shows - you are correct, if you enable "move on complete" - there is code to create new folder.

see https://github.com/elgatito/elementum/blame/v0.1.85/bittorrent/service.go#L1474

and compare to original (7 years old) code https://github.com/elgatito/elementum/blame/c2f57fde1544955fcd3abb32a7c8619f370c8d49/bittorrent/service.go#L749

for movies it always just move movie to destination folder.

my guess that you just downloaded movie's torrents that had top level folder. i have no other explanation.