search

elgatito / plugin.video.elementum

Elementum add-on for Kodi. Development of this addon has been stopped!
http://elementum.surge.sh
MIT License
483 stars 159 forks source link

[Request/Bug] Sync Watched/Unwatched with Trakt & Library integration #53

Closed burekas7 closed 6 years ago

burekas7 commented 6 years ago

Hi,

Can you add any support for sync with Trakt if items were watched on not? I have seen that you have mentioned that it should be fixed in version 29, but it's still showing all the items from the collection lists (Trakt -> Collection), it doesn't indicate the status of the items if they have been watched or not (There is no mark of 'watched')

Previous discussion is here: https://github.com/scakemyer/plugin.video.quasar/issues/518

I haven't test it yet with the library integration, but there was a problem with the library sync. After watching through the library, it doesn't mark it as watched in the kodi library. Related issue is here: https://github.com/scakemyer/plugin.video.quasar/issues/16

Thanks.

elgatito commented 6 years ago

Changes, implemented in 0.0.29 are about situations when you add something to the Kodi library, start watch from there and on stop your trakt will be update with "watched", as should be the Kodi library,as well. It's not about showing watched/unwatched status everywhere is Elementum listings.

I haven't test it yet with the library integration, but there was a problem with the library sync. After watching through the library, it doesn't mark it as watched in the kodi library.

Then you should provide log and describe what you doing.

burekas7 commented 6 years ago

OK understood. This is why I also wrote "Request". Maybe I will seprate it to two issues.

The first part is talking about the sync the watched status in the addon lists according to their status from Trakt. This is the request.

Regarding the second part, quasar updates Trakt, but doesn't sync the status in the library. So currently I'm using the Trakt addon to do that for me after doing the Update Library operation, But I just install it, so I still need to convert the library to this addon in order to verify if it's ok now. I will update soon.

elgatito commented 6 years ago

Regarding the second part, quasar updates Trakt, but doesn't sync the status in the library. So currently I'm using the Trakt addon to do that for me after doing the Update Library operation, But I just install it, so I still need to convert the library to this addon in order to verify if it's ok now.

I'm using Elementum+Trakt on a permanent basis. It's updating correctly watched status on Trakt. Just need to be sure you scrape the library with TMDB or Universal scrapers.

elgatito commented 6 years ago

v0.0.30 is now releasing. It will have unified watched status processing. Watch/Unwatch is synced to Trakt. And from Trakt there are syncs to get watched items and mark them in Kodi library. In TMDB/Trakt listings we also use unified watch.

But keep in mind - when you watch all episodes - Trakt is not marking show as watched in API, so we only know about specific episodes, that are watched.

burekas7 commented 6 years ago

OK, you have mentioned the kodi library. I still need to check it. But what about the addon itself, on version 29 when I'm for example in my Trakt Collection category, I saw all the items in the collection. It doesn't mark the item as watched there.

And thanks for you work, I appreciate this.

elgatito commented 6 years ago

Before 0.0.30 there was no Watched management inside plugin listings, they were all sent to Kodi as not-watched. All the "watched" statuses were set by Kodi somehow.

burekas7 commented 6 years ago

Today almost each regular streaming addon that have integration with Trakt have this sync inside the addon. Only in Quasar it doesn't exist, also here in Elementum. I check it with 0.0.30 and I still get all the list, there is no indication watched status or the watched marks.

elgatito commented 6 years ago

You give too much information. You can start with description how to reproduce and a log file.

burekas7 commented 6 years ago

Sorry my mistake. Thanks. I didn't get into the tv shows themselves so I didn't notice. The seasons and episodes are ok and synced. (Also Movies) But can you please add a check in the addon that if all the seasons are marked as 'watched', to mark also the TV Show as 'watched'. Is it possible?

elgatito commented 6 years ago

@burekas7 , the problem is that Trakt does not show whether Show/Season is finished and it does not total number of seasons/episodes so we can calculate that on our side. And seasons/episodes numbering also differs from TMDB, so it's not so easy to check.

burekas7 commented 6 years ago

@elgatito OK, I understood that there is no info regarding the whole show (By the way, regarding the Season you do update their status as you can see in the image). So this is exactly what I mean, regarding the TV Shows, don't relate on Trakt. Can you check if all the items (seasons) are marked as 'watched' and if so, mark the parent (The TV show as 'watched' too)?

seasons

burekas7 commented 6 years ago

@elgatito I have noticed another issue regarding the Trakt sync:

When playing a watched item it remove the watched mark and doesn't keep the status. Also it doesn't mark it again as watched according to Trakt (Even when going in again, or trying to refresh it)

Steps:

  1. Go to your collection list for example (Movies -> Trakt -> Collection)
  2. Choose a movie that already marked as watched (Synced by Trakt)
  3. Stop it somewhere in the start.
  4. The movie is now marked as unwatched, while it should be still marked as watched. (In Trakt it's still marked as watched) It seems that it doesn't resync the status after this case.
elgatito commented 6 years ago

If you start an already-watched movie and stop somewhere in the middle (less than 90% of duration), it will set progress in Kodi library and Trakt, and remove Watched status. That is expected behavior.

burekas7 commented 6 years ago

But in Trakt site it is still marked as watched because it remembers there is an old play from the past, so it remained as watched there. Also in my kodi library it's still considered as watched. Only in the addon it shows it as unwatched.

burekas7 commented 6 years ago

And what about my question/suggestion here: https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-358703930

Is it possible?

elgatito commented 6 years ago

I will try to solve it, but it will be not 100% correct, because of some differences if season/episode numbering.

elgatito commented 6 years ago

Please, try version 0.0.33 and post new kodi.log if issue still active.

As I've said before, some shows are correctly set as "watched" now, but some are not, because Trakt is using another season/episode numbering (not often, but it happens). Also Kodi is not letting programically set Season as watched, only episode and show.

Thanks

burekas7 commented 6 years ago

Thanks. But the problem is not with seasons, the problem is with the TV Shows list. And are you sure about kodi? because in other addons episodes & seasons & TV shows that based on Trakt are marked as watched. So how they can do it?

And as you said In general it's working now with 0.0.32 but not 100% There are still some TV Shows that are not marked as watched even if all the season inside them are marked as watched.

In addition there is problem with TV Shows that have a 'Specials' season. Can you add a parameter of ignoring the 'Specials' seasons in the listing. Because even Trakt doesn't success to sync these episodes because they doesn't have DBID info for them.

burekas7 commented 6 years ago

What about this problem of 'removing watched status when playing watched items'? As I said in this comment: https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-359200122 The movies is still marked as 'played' (watched) in Trakt, so why in the addon it's still show it as 'unwatched'?

elgatito commented 6 years ago

We don't know which season is specials, which is not. We only get list of seasons and episodes which are marked as watched. To know seasons numbering of Trakt we need to request each item and see it's information. This will not be implemented, because it will slow down sync a lot. It is as it is. We get seasons and episodes, if Kodi library has the same episodes in season and same seasons in show - show is marked as watched.

ziiky commented 6 years ago

U do not need to know if the seasen or series is over. Can u make 2 rules:

  1. rule where the series will get watched status if last aired episode is watched.
  2. Rule to remove watched status from series When new episode is aired
burekas7 commented 6 years ago

@elgatito I want to mention that the TV Shows issue from this comment: https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-358703930 And here: https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-359484374 is totally fixed now in 0.0.43, Great! Thank you.

But there is still sync problem with Trakt -> Movies Collection as I said here: https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-359192089 https://github.com/elgatito/plugin.video.elementum/issues/53#issuecomment-359485251 Even after watching a movie that wasn't watched, it's still showing it as unwatched. (In kodi library and in Trakt it marked as watched)

burekas7 commented 6 years ago

@elgatito There are still open issues with the Trakt sync.

Regarding TV Shows in the Trakt Collection, some tv shows are marked as watched while there are still remaining unwatched seasons & episodes.

Regarding Movies in the Trakt Collection, there are few movies that still marked as unwatched while they already have been watched (In Trakt it recognized as watched also)

Kodi log: https://paste.ubuntu.com/p/kZFPzFdfFW Elementum 0.0.44 Kodi 17.6

alanmilinovic commented 6 years ago

I just cannot belive that you didn't implemented both direction of syncing. If I have some movie marked as watched in Trakt it will not be marked as watched in your plugin. That is very bad.

elgatito commented 6 years ago

It is marked as watched in the library if it is i trakt.

alanmilinovic commented 6 years ago

I don't get it. Do I need to configure something extra, except Authorization with Elementum? I just installed Elementum and my Kodi movie library is empty. But I have plenty of movies watched on Trakt.

elgatito commented 6 years ago

Syncing watched mean setting movie as watched in Kodi's library. To add something in Kodi library - it has to be added to userlist or collection in trakt.

alanmilinovic commented 6 years ago

Can you provide me with step by step how to have movies marked as watched when I navigate through the menu items in Elementum?

alanmilinovic commented 6 years ago

I mean this should work automaticly like for an example in Exodus or any other fork of it.

burekas7 commented 6 years ago

I didn't talk on Library sync, I'm talking on sync Trakt Collection which is inside the addon with Trakt watched status.

alanmilinovic commented 6 years ago

Never mind this is not a full Trakt integration, sorry guys.

alanmilinovic commented 6 years ago

So I have to add movie into collection if I watched it outside of Kodi and also mark it as watched to be able to see that movie in Elementum addon as watched??? By the way Trakt collection shoud be used for marking something that one owns on some device like hard disk.

This sistem which this addon has is nothing more less then idiotic.

elgatito commented 6 years ago

@amilino i'd like to ask you to stop using Elementum, as well as writing here. There are a lot of alternatived and you should use them.

@burekas7 thanks to people, this issue and anything related to Trakt will be closed without any changes.